diff options
| author | Michel Dänzer <michel.daenzer@amd.com> | 2016-03-24 17:42:47 +0900 |
|---|---|---|
| committer | Adam Jackson <ajax@redhat.com> | 2016-03-24 15:47:33 -0400 |
| commit | 3b385105b2d19a1c55e9779ae88d775185eea231 (patch) | |
| tree | bb635780f887fa04119c8d50dc2538001438883a | |
| parent | 8ac0e05cc6c6e87b223ba7cb31d8856771c5d41a (diff) | |
present: Only requeue for next MSC after flip failure
This code was added to deal with the driver present hook failing, in
which case we need to wait for the next MSC before executing the
presentation.
However, it could also take effect in cases where the driver incorrectly
thinks the current MSC matches the target one (e.g. due to the kernel
interface only supporting 32-bit MSC values), in which case it could
result in the presentation getting requeued over and over.
To prevent such issues, check specifically for the target MSC
immediately following the current MSC.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94596
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Reviewed-by: Keith Packard <keithp@keithp.com>
| -rw-r--r-- | present/present.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/present/present.c b/present/present.c index 55f6aa7b1..105e2bf47 100644 --- a/present/present.c +++ b/present/present.c @@ -726,7 +726,7 @@ present_execute(present_vblank_ptr vblank, uint64_t ust, uint64_t crtc_msc) } /* If present_flip failed, we may have to requeue for the target MSC */ - if (msc_is_after(vblank->target_msc, crtc_msc) && + if (vblank->target_msc == crtc_msc + 1 && Success == present_queue_vblank(screen, vblank->crtc, vblank->event_id, |