diff options
| author | Eric Anholt <eric@anholt.net> | 2015-12-11 19:06:09 -0800 |
|---|---|---|
| committer | Eric Anholt <eric@anholt.net> | 2015-12-15 12:02:44 -0800 |
| commit | 02bcb443ee39cec1b61e5ba3e466471f3668f536 (patch) | |
| tree | 643d3b413f12ddfd944d5beafd2326405ee6e40c | |
| parent | a2140b05710cd7ca21242a9866d58ca1b5ac86cd (diff) | |
vc4: Warn instead of abort()ing on exec ioctl failures.
It's really harsh to abort() the X Server because of a momentary failure
(particularly -ENOMEM). I don't see a way to pass an -ENOMEM up the stack
from here, but we can at least log to stderr before proceeding on.
Cc: "11.1" <mesa-stable@lists.freedesktop.org>
| -rw-r--r-- | src/gallium/drivers/vc4/vc4_job.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/gallium/drivers/vc4/vc4_job.c b/src/gallium/drivers/vc4/vc4_job.c index 79bf2c49ee..78a66cc231 100644 --- a/src/gallium/drivers/vc4/vc4_job.c +++ b/src/gallium/drivers/vc4/vc4_job.c @@ -240,9 +240,11 @@ vc4_job_submit(struct vc4_context *vc4) #else ret = vc4_simulator_flush(vc4, &submit); #endif - if (ret) { - fprintf(stderr, "VC4 submit failed\n"); - abort(); + static bool warned = false; + if (ret && !warned) { + fprintf(stderr, "Draw call returned %s. " + "Expect corruption.\n", strerror(errno)); + warned = true; } } |