IR: Make metadata typeless in assembly

Now that `Metadata` is typeless, reflect that in the assembly.  These
are the matching assembly changes for the metadata/value split in
r223802.

  - Only use the `metadata` type when referencing metadata from a call
    intrinsic -- i.e., only when it's used as a `Value`.

  - Stop pretending that `ValueAsMetadata` is wrapped in an `MDNode`
    when referencing it from call intrinsics.

So, assembly like this:

    define @foo(i32 %v) {
      call void @llvm.foo(metadata !{i32 %v}, metadata !0)
      call void @llvm.foo(metadata !{i32 7}, metadata !0)
      call void @llvm.foo(metadata !1, metadata !0)
      call void @llvm.foo(metadata !3, metadata !0)
      call void @llvm.foo(metadata !{metadata !3}, metadata !0)
      ret void, !bar !2
    }
    !0 = metadata !{metadata !2}
    !1 = metadata !{i32* @global}
    !2 = metadata !{metadata !3}
    !3 = metadata !{}

turns into this:

    define @foo(i32 %v) {
      call void @llvm.foo(metadata i32 %v, metadata !0)
      call void @llvm.foo(metadata i32 7, metadata !0)
      call void @llvm.foo(metadata i32* @global, metadata !0)
      call void @llvm.foo(metadata !3, metadata !0)
      call void @llvm.foo(metadata !{!3}, metadata !0)
      ret void, !bar !2
    }
    !0 = !{!2}
    !1 = !{i32* @global}
    !2 = !{!3}
    !3 = !{}

I wrote an upgrade script that handled almost all of the tests in llvm
and many of the tests in cfe (even handling many `CHECK` lines).  I've
attached it (or will attach it in a moment if you're speedy) to PR21532
to help everyone update their out-of-tree testcases.

This is part of PR21532.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@224257 91177308-0d34-0410-b5e6-96231b3b80d8

1 files changed, 12 insertions, 12 deletions

diff --git a/test/CodeGen/X86/fold-tied-op.ll b/test/CodeGen/X86/fold-tied-op.ll
index a643d86e6f7..65b8aeb74cb 100644
--- a/test/CodeGen/X86/fold-tied-op.ll
+++ b/test/CodeGen/X86/fold-tied-op.ll
@@ -70,15 +70,15 @@ attributes #0 = { nounwind uwtable "less-precise-fpmad"="false" "no-frame-pointe
 

 !llvm.ident = !{!0}

 

-!0 = metadata !{metadata !"clang version 3.6 (trunk 219587)"}

-!1 = metadata !{metadata !2, metadata !2, i64 0}

-!2 = metadata !{metadata !"int", metadata !3, i64 0}

-!3 = metadata !{metadata !"omnipotent char", metadata !4, i64 0}

-!4 = metadata !{metadata !"Simple C/C++ TBAA"}

-!5 = metadata !{metadata !6, metadata !2, i64 0}

-!6 = metadata !{metadata !"XXH_state64_t", metadata !2, i64 0, metadata !2, i64 4, metadata !7, i64 8, metadata !7, i64 16, metadata !7, i64 24}

-!7 = metadata !{metadata !"long long", metadata !3, i64 0}

-!8 = metadata !{metadata !6, metadata !7, i64 16}

-!9 = metadata !{metadata !6, metadata !7, i64 24}

-!10 = metadata !{metadata !6, metadata !7, i64 8}

-!11 = metadata !{metadata !7, metadata !7, i64 0}

+!0 = !{!"clang version 3.6 (trunk 219587)"}

+!1 = !{!2, !2, i64 0}

+!2 = !{!"int", !3, i64 0}

+!3 = !{!"omnipotent char", !4, i64 0}

+!4 = !{!"Simple C/C++ TBAA"}

+!5 = !{!6, !2, i64 0}

+!6 = !{!"XXH_state64_t", !2, i64 0, !2, i64 4, !7, i64 8, !7, i64 16, !7, i64 24}

+!7 = !{!"long long", !3, i64 0}

+!8 = !{!6, !7, i64 16}

+!9 = !{!6, !7, i64 24}

+!10 = !{!6, !7, i64 8}

+!11 = !{!7, !7, i64 0}