summaryrefslogtreecommitdiff
path: root/fs/befs/debug.c
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2017-07-30 23:33:01 -0400
committerTheodore Ts'o <tytso@mit.edu>2017-07-30 23:33:01 -0400
commita3bb2d5587521eea6dab2d05326abb0afb460abd (patch)
tree5c3bca981b65fa8c69b0552b3c4d9856dcbfaeff /fs/befs/debug.c
parent397e434176bb62bc6068d2210af1d876c6212a7e (diff)
ext4: Don't clear SGID when inheriting ACLs
When new directory 'DIR1' is created in a directory 'DIR0' with SGID bit set, DIR1 is expected to have SGID bit set (and owning group equal to the owning group of 'DIR0'). However when 'DIR0' also has some default ACLs that 'DIR1' inherits, setting these ACLs will result in SGID bit on 'DIR1' to get cleared if user is not member of the owning group. Fix the problem by moving posix_acl_update_mode() out of __ext4_set_acl() into ext4_set_acl(). That way the function will not be called when inheriting ACLs which is what we want as it prevents SGID bit clearing and the mode has been properly set by posix_acl_create() anyway. Fixes: 073931017b49d9458aa351605b43a7e34598caef CC: stable@vger.kernel.org Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Jan Kara <jack@suse.cz> Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>
Diffstat (limited to 'fs/befs/debug.c')
0 files changed, 0 insertions, 0 deletions