summaryrefslogtreecommitdiff
path: root/migration
diff options
context:
space:
mode:
authorPeter Xu <peterx@redhat.com>2017-06-28 15:15:44 +0800
committerJuan Quintela <quintela@redhat.com>2017-06-28 11:18:39 +0200
commit01f6e14c78f480ade5521139019fdf930a7affaa (patch)
tree085d6578cbf1dfcc7beb84d80bb73ba8b9f058b7 /migration
parent9d18af93b39544a829f398c9e0cfd0e6ae7deb13 (diff)
migration: add comment for TYPE_MIGRATE
It'll be strange that the migration object inherits TYPE_DEVICE. Add some explanations to it. Signed-off-by: Peter Xu <peterx@redhat.com> Message-Id: <1498634144-26508-1-git-send-email-peterx@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'migration')
-rw-r--r--migration/migration.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/migration/migration.c b/migration/migration.c
index b1b08250ce..2398a9db4f 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2046,6 +2046,14 @@ static void migration_instance_init(Object *obj)
static const TypeInfo migration_type = {
.name = TYPE_MIGRATION,
+ /*
+ * NOTE: "migration" itself is not really a device. We used
+ * TYPE_DEVICE here only to leverage some existing QDev features
+ * like "-global" properties, and HW_COMPAT_* fields (which are
+ * finally applied as global properties as well). If one day the
+ * global property feature can be migrated from QDev to QObject in
+ * general, then we can switch to QObject as well.
+ */
.parent = TYPE_DEVICE,
.class_init = migration_class_init,
.class_size = sizeof(MigrationClass),