diff options
| author | Gabriel L. Somlo <somlo@cmu.edu> | 2015-06-08 14:10:45 -0400 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2015-06-10 08:00:37 +0200 |
| commit | 48779e501810c5046ff8af7b9cf9c99bec2928a1 (patch) | |
| tree | 001c2ea1184e13405c830511092399bdfbd92162 /hw/ppc/mac_oldworld.c | |
| parent | 1edd34b638f73d39a175fbc4f9ad5c97800d7470 (diff) | |
fw_cfg: fix FW_CFG_BOOT_DEVICE update on ppc and sparc
On ppc, sparc, and sparc64, the value of the FW_CFG_BOOT_DEVICE 16bit
fw_cfg entry is repeatedly modified from a series of callbacks, which
currently results in the previous value's dynamically allocated memory
being leaked.
This patch switches updating to the new fw_cfg_modify_i16() call, which
does not cause memory leaks.
Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'hw/ppc/mac_oldworld.c')
| -rw-r--r-- | hw/ppc/mac_oldworld.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c index f26133dedd..99879dd2d5 100644 --- a/hw/ppc/mac_oldworld.c +++ b/hw/ppc/mac_oldworld.c @@ -52,7 +52,7 @@ static void fw_cfg_boot_set(void *opaque, const char *boot_device, Error **errp) { - fw_cfg_add_i16(opaque, FW_CFG_BOOT_DEVICE, boot_device[0]); + fw_cfg_modify_i16(opaque, FW_CFG_BOOT_DEVICE, boot_device[0]); } static uint64_t translate_kernel_address(void *opaque, uint64_t addr) |