summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJuan Quintela <quintela@redhat.com>2010-03-04 10:00:30 +0100
committerAnthony Liguori <aliguori@us.ibm.com>2010-03-09 11:22:59 -0600
commit48b66db9ea19e30ac360872dae590e79cd009d1a (patch)
treea2b2b6c0892f184277d1fb6a02d25014bcdb8de2
parente53dbee05dfabea5533f6bdf61547b2d3d59a965 (diff)
cow: return errno instead of -1
Remove not needed ret = 0 assignment. Signed-off-by: Juan Quintela <quintela@redhat.com> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
-rw-r--r--block/cow.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/block/cow.c b/block/cow.c
index 3733385840..97e9745fc9 100644
--- a/block/cow.c
+++ b/block/cow.c
@@ -224,7 +224,7 @@ static int cow_create(const char *filename, QEMUOptionParameter *options)
cow_fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY,
0644);
if (cow_fd < 0)
- return -1;
+ return -errno;
memset(&cow_header, 0, sizeof(cow_header));
cow_header.magic = cpu_to_be32(COW_MAGIC);
cow_header.version = cpu_to_be32(COW_VERSION);
@@ -251,7 +251,7 @@ static int cow_create(const char *filename, QEMUOptionParameter *options)
cow_header.size = cpu_to_be64(image_sectors * 512);
ret = qemu_write_full(cow_fd, &cow_header, sizeof(cow_header));
if (ret != sizeof(cow_header)) {
- ret = -1;
+ ret = -errno;
goto exit;
}
@@ -262,7 +262,6 @@ static int cow_create(const char *filename, QEMUOptionParameter *options)
goto exit;
}
- ret = 0;
exit:
close(cow_fd);
return ret;