summaryrefslogtreecommitdiff
path: root/docs/submittingpatches.html
diff options
context:
space:
mode:
authorEmil Velikov <emil.velikov@collabora.com>2016-11-16 11:54:54 +0000
committerEmil Velikov <emil.l.velikov@gmail.com>2016-11-21 15:08:14 +0000
commitb571c075e9ab48ccbb71879861117171d2344c6b (patch)
treedb223121c98aef9c8148072393581117f423c356 /docs/submittingpatches.html
parent07384468afdbf6eb2ce43072452a6a87c261b56a (diff)
docs/submittingpatches: fix tags mis/abuse
Fix the odd tag so that we're HTML 4.01 Traditional compliant Signed-off-by: Emil Velikov <emil.velikov@collabora.com> Reviewed-by: Brian Paul <brianp@vmware.com>
Diffstat (limited to 'docs/submittingpatches.html')
-rw-r--r--docs/submittingpatches.html6
1 files changed, 5 insertions, 1 deletions
diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html
index 39b615bc9a..d3e86f5b44 100644
--- a/docs/submittingpatches.html
+++ b/docs/submittingpatches.html
@@ -134,7 +134,7 @@ to check for regressions.
<p>
Patches should be sent to the mesa-dev mailing list for review:
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">
-mesa-dev@lists.freedesktop.org<a/>.
+mesa-dev@lists.freedesktop.org</a>.
When submitting a patch make sure to use
<a href="https://git-scm.com/docs/git-send-email">git send-email</a>
rather than attaching patches to emails. Sending patches as
@@ -161,6 +161,7 @@ state of your old patches to Superseded.
<p>
When you've reviewed a patch on the mailing list, please be unambiguous
about your review. That is, state either
+</p>
<pre>
Reviewed-by: Joe Hacker &lt;jhacker@foo.com&gt;
</pre>
@@ -168,14 +169,17 @@ or
<pre>
Acked-by: Joe Hacker &lt;jhacker@foo.com&gt;
</pre>
+<p>
Rather than saying just "LGTM" or "Seems OK".
</p>
<p>
If small changes are suggested, it's OK to say something like:
+</p>
<pre>
With the above fixes, Reviewed-by: Joe Hacker &lt;jhacker@foo.com&gt;
</pre>
+<p>
which tells the patch author that the patch can be committed, as long
as the issues are resolved first.
</p>