diff options
| author | Jason Ekstrand <jason.ekstrand@intel.com> | 2017-03-31 15:23:35 -0700 |
|---|---|---|
| committer | Jason Ekstrand <jason.ekstrand@intel.com> | 2017-04-04 18:33:52 -0700 |
| commit | f938354362655a378d474c5f79c52cea9852ab91 (patch) | |
| tree | 370169fb9ba0c26226f484eb0e7e1a597e9d01fa | |
| parent | 5d1ba2cb04f58b0c887304f0b8adda0b5623a710 (diff) | |
i965/blorp: Align vertex buffers to 64B
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Cc: "13.0 17.0" <mesa-stable@lists.freedesktop.org>
| -rw-r--r-- | src/mesa/drivers/dri/i965/genX_blorp_exec.c | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/src/mesa/drivers/dri/i965/genX_blorp_exec.c b/src/mesa/drivers/dri/i965/genX_blorp_exec.c index f9334ee13d..b7a23afab4 100644 --- a/src/mesa/drivers/dri/i965/genX_blorp_exec.c +++ b/src/mesa/drivers/dri/i965/genX_blorp_exec.c @@ -122,8 +122,20 @@ blorp_alloc_vertex_buffer(struct blorp_batch *batch, uint32_t size, assert(batch->blorp->driver_ctx == batch->driver_batch); struct brw_context *brw = batch->driver_batch; + /* From the Skylake PRM, 3DSTATE_VERTEX_BUFFERS: + * + * "The VF cache needs to be invalidated before binding and then using + * Vertex Buffers that overlap with any previously bound Vertex Buffer + * (at a 64B granularity) since the last invalidation. A VF cache + * invalidate is performed by setting the "VF Cache Invalidation Enable" + * bit in PIPE_CONTROL." + * + * This restriction first appears in the Skylake PRM but the internal docs + * also list it as being an issue on Broadwell. In order to avoid this + * problem, we align all vertex buffer allocations to 64 bytes. + */ uint32_t offset; - void *data = brw_state_batch(brw, size, 32, &offset); + void *data = brw_state_batch(brw, size, 64, &offset); *addr = (struct blorp_address) { .buffer = brw->batch.bo, |