diff options
| author | Nicolai Hähnle <nicolai.haehnle@amd.com> | 2017-02-02 21:50:32 +0100 |
|---|---|---|
| committer | Nicolai Hähnle <nicolai.haehnle@amd.com> | 2017-04-05 10:31:01 +0200 |
| commit | d6fcbe1c2a88a33128bdf3ae02705d65dd9a3e8e (patch) | |
| tree | b373fdbdb216e1b31a447d4a18c166d7c909736a | |
| parent | 94227684c49a03c91d2ae4d978fa0ae72084e013 (diff) | |
mesa: implement sparse storage buffer allocation
v2:
- spec quote and style (Ian)
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
| -rw-r--r-- | src/mesa/main/bufferobj.c | 29 |
1 files changed, 23 insertions, 6 deletions
diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index cbd92289b6..a4ccf8c5e5 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -1536,16 +1536,33 @@ _mesa_buffer_storage(struct gl_context *ctx, struct gl_buffer_object *bufObj, return; } - if (flags & ~(GL_MAP_READ_BIT | - GL_MAP_WRITE_BIT | - GL_MAP_PERSISTENT_BIT | - GL_MAP_COHERENT_BIT | - GL_DYNAMIC_STORAGE_BIT | - GL_CLIENT_STORAGE_BIT)) { + GLbitfield valid_flags = GL_MAP_READ_BIT | + GL_MAP_WRITE_BIT | + GL_MAP_PERSISTENT_BIT | + GL_MAP_COHERENT_BIT | + GL_DYNAMIC_STORAGE_BIT | + GL_CLIENT_STORAGE_BIT; + + if (ctx->Extensions.ARB_sparse_buffer) + valid_flags |= GL_SPARSE_STORAGE_BIT_ARB; + + if (flags & ~valid_flags) { _mesa_error(ctx, GL_INVALID_VALUE, "%s(invalid flag bits set)", func); return; } + /* The Errors section of the GL_ARB_sparse_buffer spec says: + * + * "INVALID_VALUE is generated by BufferStorage if <flags> contains + * SPARSE_STORAGE_BIT_ARB and <flags> also contains any combination of + * MAP_READ_BIT or MAP_WRITE_BIT." + */ + if (flags & GL_SPARSE_STORAGE_BIT_ARB && + flags & (GL_MAP_READ_BIT | GL_MAP_WRITE_BIT)) { + _mesa_error(ctx, GL_INVALID_VALUE, "%s(SPARSE_STORAGE and READ/WRITE)", func); + return; + } + if (flags & GL_MAP_PERSISTENT_BIT && !(flags & (GL_MAP_READ_BIT | GL_MAP_WRITE_BIT))) { _mesa_error(ctx, GL_INVALID_VALUE, |