diff options
| author | Will Deacon <will.deacon@arm.com> | 2011-11-23 11:28:25 +0100 |
|---|---|---|
| committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2011-11-26 21:58:53 +0000 |
| commit | c36ef4b1762302a493c6cb754073bded084700e2 (patch) | |
| tree | 2ea1bf8bb2ee7d972c09e0b29cc178c4c930ab4a /arch/arm/lib/setbit.S | |
| parent | c89cefed35c8c5f53f36757f8a6768e390394ee3 (diff) | |
ARM: 7171/1: unwind: add unwind directives to bitops assembly macros
The bitops functions (e.g. _test_and_set_bit) on ARM do not have unwind
annotations and therefore the kernel cannot backtrace out of them on a
fatal error (for example, NULL pointer dereference).
This patch annotates the bitops assembly macros with UNWIND annotations
so that we can produce a meaningful backtrace on error. Callers of the
macros are modified to pass their function name as a macro parameter,
enforcing that the macros are used as standalone function implementations.
Acked-by: Dave Martin <dave.martin@linaro.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/lib/setbit.S')
| -rw-r--r-- | arch/arm/lib/setbit.S | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/arch/arm/lib/setbit.S b/arch/arm/lib/setbit.S index bbee5c66a23e..618fedae4b37 100644 --- a/arch/arm/lib/setbit.S +++ b/arch/arm/lib/setbit.S @@ -12,6 +12,4 @@ #include "bitops.h" .text -ENTRY(_set_bit) - bitop orr -ENDPROC(_set_bit) +bitop _set_bit, orr |