diff options
| author | Takashi Iwai <tiwai@suse.de> | 2008-06-10 17:53:35 +0200 |
|---|---|---|
| committer | Jaroslav Kysela <perex@perex.cz> | 2008-06-13 16:47:23 +0200 |
| commit | a6a950a8a8e1431e8527809339e089ac926a7d34 (patch) | |
| tree | ea9ff916ee9a8f1a58cb2afaeb634a932876736b | |
| parent | 8c53b96f229aa6e27f17855cbbf8e4243868a3a9 (diff) | |
ALSA: hda - Add a warning if pending IRQ is found
The pending IRQ handling is a very hackish workaround and should be
avoided as much as possible via a larger bdl_pos_adj option value.
Put a warning message if this situation occurs so that the user may have
a chance to notice that something is wrong.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
| -rw-r--r-- | sound/pci/hda/hda_intel.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 9b2dc0669b94..ec4ae2d94000 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -374,6 +374,7 @@ struct azx { unsigned int single_cmd :1; unsigned int polling_mode :1; unsigned int msi :1; + unsigned int irq_pending_warned :1; /* for debugging */ unsigned int last_cmd; /* last issued command (to sync) */ @@ -1562,6 +1563,14 @@ static void azx_irq_pending_work(struct work_struct *work) struct azx *chip = container_of(work, struct azx, irq_pending_work); int i, pending; + if (!chip->irq_pending_warned) { + printk(KERN_WARNING + "hda-intel: IRQ timing workaround is activated " + "for card #%d. Suggest a bigger bdl_pos_adj.\n", + chip->card->number); + chip->irq_pending_warned = 1; + } + for (;;) { pending = 0; spin_lock_irq(&chip->reg_lock); |