summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAdam Jackson <ajax@nwnk.net>2006-03-15 16:32:05 +0000
committerAdam Jackson <ajax@nwnk.net>2006-03-15 16:32:05 +0000
commit72cc6307257fcbb800267464487bf918ee674328 (patch)
tree22ee3145cf500b3c076f8c95aa329b08cf92088f
parent460f2ea4a594a53536f34c4ad27795fceec50bcc (diff)
Coverity #491: Check version number correctly.
-rw-r--r--ChangeLog3
-rwxr-xr-xdamageext/damageext.c2
2 files changed, 4 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index c96630b54..d6da06445 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -12,6 +12,9 @@
* hw/xfree86/loader/loader.c:
Coverity #484: Fix an off-by-one in module refcounting.
+ * damageext/damageext.c:
+ Coverity #491: Check version number correctly.
+
2006-03-15 Benjamin Herrenschmidt <benh@kernel.crashing.org>
* hw/xfree86/dri/dri.c: (DRIExtensionInit):
diff --git a/damageext/damageext.c b/damageext/damageext.c
index 616d55ecc..225f9ecf0 100755
--- a/damageext/damageext.c
+++ b/damageext/damageext.c
@@ -298,7 +298,7 @@ ProcDamageDispatch (ClientPtr client)
REQUEST(xDamageReq);
DamageClientPtr pDamageClient = GetDamageClient (client);
- if (pDamageClient->major_version > NUM_VERSION_REQUESTS)
+ if (pDamageClient->major_version >= NUM_VERSION_REQUESTS)
return BadRequest;
if (stuff->damageReqType > version_requests[pDamageClient->major_version])
return BadRequest;