summaryrefslogtreecommitdiff
path: root/src/kmscon_main.c
diff options
context:
space:
mode:
authorDavid Herrmann <dh.herrmann@googlemail.com>2012-10-27 19:21:56 +0200
committerDavid Herrmann <dh.herrmann@googlemail.com>2012-10-27 19:21:56 +0200
commitf5a98b0c6b6d26e5ceada399fe8e56734ed53dea (patch)
tree19543ff65f7d28259d3f993d4c13b3b08650d61a /src/kmscon_main.c
parente495126c800afc7ff9e6398ae3c980d78db66459 (diff)
kmscon: fix --fbdev implying --all-gpus
We currently have no code that sets PRIMARY flags for fbdev devices so this logic does not make sense with --fbdev. Hence, imply --all-gpus when --fbdev is set. Reported-by: Ran Benita <ran234@gmail.com> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
Diffstat (limited to 'src/kmscon_main.c')
-rw-r--r--src/kmscon_main.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/kmscon_main.c b/src/kmscon_main.c
index ea3ef01..bc52aaf 100644
--- a/src/kmscon_main.c
+++ b/src/kmscon_main.c
@@ -224,7 +224,12 @@ static int app_seat_add_video(struct app_seat *seat,
}
}
- if (!seat->conf->all_gpus) {
+ /* with --all-gpus we avoid any further filtering. With --fbdev we
+ * already filtered all non-fbdev devices so there is currently no
+ * reason to do further filtering, either.
+ * TODO: We need to set PRIMARY flags to fbdev devices, too. Otherwise
+ * we might end up with the same problems as DRM devices have. */
+ if (!seat->conf->all_gpus && !seat->conf->fbdev) {
if (seat->conf->primary_gpu_only && !(flags & UTERM_MONITOR_PRIMARY)) {
log_info("ignoring video device %s on seat %s as it is no primary GPU",
node, seat->name);