diff options
| author | Ben Widawsky <ben@bwidawsk.net> | 2011-12-12 19:21:57 -0800 |
|---|---|---|
| committer | Keith Packard <keithp@keithp.com> | 2012-01-03 09:09:44 -0800 |
| commit | e2971bdab2b761683353da383c0fd5ac704d1cca (patch) | |
| tree | e85a6591108ae7a5aa0cf0bb2bb6a1bc85b1ae5e /lib/string_helpers.c | |
| parent | 7a7e8734ac3235efafd34819b27fbdf5417e6d60 (diff) | |
drm/i915: relative_constants_mode race fix
dev_priv keeps track of the current addressing mode that gets set at
execbuffer time. Unfortunately the existing code was doing this before
acquiring struct_mutex which leaves a race with another thread also
doing an execbuffer. If that wasn't bad enough, relocate_slow drops
struct_mutex which opens a much more likely error where another thread
comes in and modifies the state while relocate_slow is being slow.
The solution here is to just defer setting this state until we
absolutely need it, and we know we'll have struct_mutex for the
remainder of our code path.
v2: Keith noticed a bug in the original patch.
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Keith Packard <keithp@keithp.com>
Diffstat (limited to 'lib/string_helpers.c')
0 files changed, 0 insertions, 0 deletions