summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAdam Jackson <ajax@nwnk.net>2006-03-15 16:33:12 +0000
committerAdam Jackson <ajax@nwnk.net>2006-03-15 16:33:12 +0000
commit152090ce442e94de1ae920208a92931af6493c8c (patch)
tree185bbbef9499c165780faa805f099b22ed4d6845
parent72cc6307257fcbb800267464487bf918ee674328 (diff)
Coverity #487: Check version number correctly.
-rw-r--r--ChangeLog3
-rwxr-xr-xxfixes/xfixes.c2
2 files changed, 4 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index d6da06445..77037dc12 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -15,6 +15,9 @@
* damageext/damageext.c:
Coverity #491: Check version number correctly.
+ * xfixes/xfixes.c:
+ Coverity #487: Check version number correctly.
+
2006-03-15 Benjamin Herrenschmidt <benh@kernel.crashing.org>
* hw/xfree86/dri/dri.c: (DRIExtensionInit):
diff --git a/xfixes/xfixes.c b/xfixes/xfixes.c
index 9364309f4..a0e656dd8 100755
--- a/xfixes/xfixes.c
+++ b/xfixes/xfixes.c
@@ -143,7 +143,7 @@ ProcXFixesDispatch (ClientPtr client)
REQUEST(xXFixesReq);
XFixesClientPtr pXFixesClient = GetXFixesClient (client);
- if (pXFixesClient->major_version > NUM_VERSION_REQUESTS)
+ if (pXFixesClient->major_version >= NUM_VERSION_REQUESTS)
return BadRequest;
if (stuff->xfixesReqType > version_requests[pXFixesClient->major_version])
return BadRequest;