1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
|
/* Copyright 2012 VMware, Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice (including the next
* paragraph) shall be included in all copies or substantial portions of the
* Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
* IN THE SOFTWARE.
*/
/**
* \file integer-errors.c
* Do error checking for functions taking signed/unsigned integer
* (non-normalized) formats, such as glTex[Sub]Image, glDrawPixels and
* glReadPixels.
*/
#include "piglit-util-gl-common.h"
PIGLIT_GL_TEST_CONFIG_BEGIN
config.window_width = 100;
config.window_height = 100;
config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_ALPHA | PIGLIT_GL_VISUAL_DOUBLE;
PIGLIT_GL_TEST_CONFIG_END
static bool
test_api_errors(void)
{
/* clear any prev errors */
while (glGetError())
;
/* use a new tex obj */
glBindTexture(GL_TEXTURE_2D, 42);
/* Check that glDrawPixels of integer data is illegal */
{
static const GLfloat pixel[4] = {0, 0, 0, 0};
glDrawPixels(1, 1, GL_RGBA_INTEGER_EXT, GL_INT, pixel);
if (!piglit_check_gl_error(GL_INVALID_OPERATION))
return false;
}
/* Check glTexImage for invalid internalFormat/format/type combos */
{
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA16UI_EXT, 1, 1, 0,
GL_RGBA_INTEGER, GL_FLOAT, NULL);
if (!piglit_check_gl_error(GL_INVALID_ENUM))
return false;
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, 4, 4, 0,
GL_RGBA_INTEGER, GL_SHORT, NULL);
if (!piglit_check_gl_error(GL_INVALID_OPERATION))
return false;
}
/* Check glTexSubImage for invalid format/type combination */
{
/* make valid texture image here */
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA32UI_EXT, 8, 8, 0,
GL_RGBA_INTEGER, GL_UNSIGNED_INT, NULL);
if (!piglit_check_gl_error(GL_NO_ERROR))
return false;
glTexSubImage2D(GL_TEXTURE_2D, 0,
0, 0, 4, 4,
GL_RGBA_INTEGER, GL_FLOAT, NULL);
if (!piglit_check_gl_error(GL_INVALID_ENUM))
return false;
}
/* Check for GL_INVALID_OPERATION when trying to copy framebuffer pixels
* to an integer texture when the framebuffer is not an integer format.
*/
{
/* make valid texture image here */
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA16UI_EXT, 4, 4, 0,
GL_RGBA_INTEGER, GL_UNSIGNED_SHORT, NULL);
if (!piglit_check_gl_error(GL_NO_ERROR))
return false;
glCopyTexSubImage2D(GL_TEXTURE_2D, 0,
0, 0, 0, 0, 4, 4);
if (!piglit_check_gl_error(GL_INVALID_OPERATION))
return false;
}
/* Is GL_INVALID_ENUM generated by glReadPixels? */
{
GLfloat buf[64];
glReadPixels(0, 0, 4, 4, GL_RGBA_INTEGER, GL_FLOAT, buf);
if (!piglit_check_gl_error(GL_INVALID_ENUM))
return false;
}
/* Is GL_INVALID_OPERATION generated by glReadPixels? */
{
GLuint buf[64];
glReadPixels(0, 0, 4, 4, GL_RGBA_INTEGER, GL_UNSIGNED_INT, buf);
if (!piglit_check_gl_error(GL_INVALID_OPERATION))
return false;
}
return true;
}
/**
* Test specific combinations of (internalFormat, format, type) with
* glTexImage to see that they're accepted (no GL errors).
*/
static bool
test_teximage_format_combos(void)
{
/* These format combinations should all work */
struct {
GLenum intFormat, srcFormat, srcType;
} formats[] = {
{ GL_RGBA8UI_EXT, GL_RGBA_INTEGER, GL_UNSIGNED_BYTE },
{ GL_RGBA8UI_EXT, GL_RGBA_INTEGER, GL_SHORT },
{ GL_RGBA8UI_EXT, GL_RGBA_INTEGER, GL_UNSIGNED_INT_8_8_8_8 },
{ GL_RGBA8UI_EXT, GL_BGRA_INTEGER, GL_UNSIGNED_INT_8_8_8_8 },
{ GL_LUMINANCE8I_EXT, GL_RGBA_INTEGER, GL_UNSIGNED_INT_8_8_8_8 },
{ GL_RGB16I_EXT, GL_RGB_INTEGER, GL_UNSIGNED_SHORT_5_6_5 },
{ GL_RGB32I_EXT, GL_RGB_INTEGER, GL_UNSIGNED_SHORT_5_6_5 }
};
int i;
GLenum err;
bool pass = GL_TRUE;
while (glGetError() != GL_NO_ERROR)
;
for (i = 0; i < ARRAY_SIZE(formats); i++) {
glTexImage2D(GL_TEXTURE_2D, 0, formats[i].intFormat,
16, 16, 0,
formats[i].srcFormat, formats[i].srcType, NULL);
err = glGetError();
if (err != GL_NO_ERROR) {
fprintf(stderr,
"integer-errors failure: glTexImage2D(0x%x, 0x%x, 0x%x)"
" generated error 0x%x (case %d)\n",
formats[i].intFormat,
formats[i].srcFormat,
formats[i].srcType, err, i);
pass = false;
}
}
return pass;
}
enum piglit_result
piglit_display(void)
{
return PIGLIT_PASS;
}
void
piglit_init(int argc, char **argv)
{
bool pass;
piglit_require_gl_version(30);
pass = test_api_errors();
pass = pass && test_teximage_format_combos();
piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
}
|