diff options
| author | Wim Taymans <wtaymans@redhat.com> | 2017-02-20 12:16:32 +0100 |
|---|---|---|
| committer | Wim Taymans <wtaymans@redhat.com> | 2017-02-20 12:16:32 +0100 |
| commit | a15f7ad8f86d6331272024530b940577de6c74e3 (patch) | |
| tree | c37df93021378ed9db8e4cdc5971f09ff1306acb | |
| parent | c1bcf748cc06d567ac4225bc3e5feea8dccbbf80 (diff) | |
info: put () around macro arguments
Put braces around macro arguments or else we might run into problems
with operater precedence.
| -rw-r--r-- | gst/gstinfo.h | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/gst/gstinfo.h b/gst/gstinfo.h index f8be4d26e..31992b78f 100644 --- a/gst/gstinfo.h +++ b/gst/gstinfo.h @@ -434,16 +434,16 @@ void gst_printerrln (const gchar * format, ...) G_GNUC_PRINT * see https://bugzilla.gnome.org/show_bug.cgi?id=764526 */ #define gst_debug_add_log_function(func,data,notify) \ G_STMT_START{ \ - if (func == (void *) gst_debug_log_default) { \ + if ((func) == (void *) gst_debug_log_default) { \ gst_debug_add_log_function(NULL,data,notify); \ } else { \ gst_debug_add_log_function(func,data,notify); \ } \ }G_STMT_END -#define gst_debug_remove_log_function(func) \ - (func == (void *) gst_debug_log_default) ? \ - gst_debug_remove_log_function(NULL) : \ +#define gst_debug_remove_log_function(func) \ + ((func) == (void *) gst_debug_log_default) ? \ + gst_debug_remove_log_function(NULL) : \ gst_debug_remove_log_function(func) /** @@ -563,7 +563,7 @@ GST_EXPORT GstDebugLevel _gst_debug_min; */ #ifdef G_HAVE_ISO_VARARGS #define GST_CAT_LEVEL_LOG(cat,level,object,...) G_STMT_START{ \ - if (G_UNLIKELY (level <= GST_LEVEL_MAX && level <= _gst_debug_min)) { \ + if (G_UNLIKELY ((level) <= GST_LEVEL_MAX && (level) <= _gst_debug_min)) { \ gst_debug_log ((cat), (level), __FILE__, GST_FUNCTION, __LINE__, \ (GObject *) (object), __VA_ARGS__); \ } \ @@ -571,7 +571,7 @@ GST_EXPORT GstDebugLevel _gst_debug_min; #else /* G_HAVE_GNUC_VARARGS */ #ifdef G_HAVE_GNUC_VARARGS #define GST_CAT_LEVEL_LOG(cat,level,object,args...) G_STMT_START{ \ - if (G_UNLIKELY (level <= GST_LEVEL_MAX && level <= _gst_debug_min)) { \ + if (G_UNLIKELY ((level) <= GST_LEVEL_MAX && (level) <= _gst_debug_min)) { \ gst_debug_log ((cat), (level), __FILE__, GST_FUNCTION, __LINE__, \ (GObject *) (object), ##args ); \ } \ @@ -581,7 +581,7 @@ static inline void GST_CAT_LEVEL_LOG_valist (GstDebugCategory * cat, GstDebugLevel level, gpointer object, const char *format, va_list varargs) { - if (G_UNLIKELY (level <= GST_LEVEL_MAX && level <= _gst_debug_min)) { + if (G_UNLIKELY ((level) <= GST_LEVEL_MAX && (level) <= _gst_debug_min)) { gst_debug_log_valist (cat, level, "", "", 0, (GObject *) object, format, varargs); } |