summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2014-12-19Revert "launch: Disable autospawn by default when systemd daemon support is ↵v5.99.2David Henningsson4-9/+2
enabled." This reverts commit 7276faca72e9696d4891daff139aee52509f43bf. Using the new systemd socket activation for PulseAudio will cause PulseAudio to not have any connection with D-Bus, breaking device reservation protocol, module-jackdbus-detect and module-dbus-protocol. Therefore, autospawn is now still enabled by default even if you build with systemd daemon headers.
2014-12-19card-restore: Fix profile restoring with bluetoothTanu Kaskinen1-0/+34
The bluetooth card is created when the first profile becomes available, which means that the card may have profiles that are not available when the card is initialized. If module-card-restore tries to restore such profile, that will fail, and the card will be initialized with the "off" profile active. This patch modifies module-card-restore so that if follows the profile availability status, and when the saved profile becomes available, it is activated. Additionally, module-card-restore is modified so that it doesn't even try to restore unavailable profiles, when the necessary information is available. In practice there are two existing places where the profile is restored, and only one of those contexts has the necessary information available. Unfortunately, it's the more important context (card creation) where the information is not available. This means that module-card-restore will set the initial profile of a new card even if the profile is unavailable, and this will cause an ugly warning in the log, even though there's nothing abnormal happening. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=87081
2014-12-19bluez5: Do not suspend on no -> unknown profile transitionsDavid Henningsson1-1/+3
In case a transport is currently disconnected and transitions to idle, that should not count as a "remote hang up" event. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-12-15introspect: Minor documentation fixArun Raghavan1-1/+1
2014-12-10memblock: Initialize mempool object to zeroDavid Henningsson1-2/+1
This fixes a "use of uninitialised value" error in previous memblock commit. Reported-by: Alexander Patrakov <patrakov@gmail.com> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-12-08srbchannel: Check return value of pa_memblock_new_poolDavid Henningsson1-0/+3
In case PA_MEMPOOL_DISABLE is set, pa_memblock_new_pool can return NULL. It does not make sense to set up a srbchannel without a shared memory pool, so just fail in this case. Reported-by: Alexander Patrakov <patrakov@gmail.com> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-12-08i18n: Add French translation for "Speaker"Tanu Kaskinen1-1/+1
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=87073
2014-12-08Warn on loading module-dbus-protocolAlexander E. Patrakov1-0/+5
See also https://www.mail-archive.com/ubuntu-audio-dev@lists.launchpad.net/msg00268.html The warning may be useful for users who carried over the module-loading statement from default configuration files shipped with old PulseAudio versions. Signed-off-by: Alexander E. Patrakov <patrakov@gmail.com>
2014-12-08module-equalizer-sink: remove erroneous fixmeJason Newton1-2/+0
pa_memblockq_drop is guaranteed to drop the chunk we just extracted from the memblockq which internally unrefs the chunk.
2014-12-08module-equalizer-sink: use fftwf_free in all the right placesJason Newton1-8/+8
Several mallocs were made using fftwf_malloc and were erroneously freed by pa_xfree. This patch corrects these calls of pa_xfree to fftwf_free.
2014-12-08Warn on loading module-equalizer-sinkAlexander E. Patrakov1-0/+4
See objections to the code in this email: http://lists.freedesktop.org/archives/pulseaudio-discuss/2014-March/020174.html Signed-off-by: Alexander E. Patrakov <patrakov@gmail.com>
2014-12-08memblock: Avoid block ID collisions when exporting memory blocksDavid Henningsson1-3/+13
Every new memexport object now gets an ever increasing base index, that prevents block ID collisions between different memexport objects on the same pstream. In particular, this prevents block ID collision between the srb memblock (which has its own memexport object) and audio data blocks. Reported-by: Peter Meerwald <pmeerw@pmeerw.net> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-12-05module: Fix unsafe iterationTanu Kaskinen3-5/+11
This fixes an issue when requesting module unload for module-bluetooth-discover. When unloading the module, it also unloads module-bluez4-discover and/or module-bluez5-discover, and that invalidated the state variable that was used for iterating through the modules idxset. The pa_module.unload_requested flag could now otherwise be removed, but it's still being (ab)used in the bluetooth modules.
2014-12-04core-util: Fix build on mingw32David Henningsson1-0/+2
mingw32 does not have "getuid", so ifdef it properly. Reported-by: Michael DePaulo <mikedep333@gmail.com> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-12-03bluez5: Fix free order of adapters and devicesDavid Henningsson1-3/+3
Because the adapters reference the devices hashmap on free, we mush free the adapters hashmap first and then the devices hashmap. Reported-by: Alexander Patrakov <patrakov@gmail.com> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-12-03build-sys: Don't build srbchannel-test on targets without srbchannelDavid Henningsson2-1/+6
Reported-by: Felipe Sateler <fsateler@debian.org> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-12-01Fix #defines for Debian GNU/kFreeBSDFelipe Sateler6-15/+19
Because debian does not run with the freebsd libc, but rather uses the GNU one, it chose to not define __FreeBSD__, but rather __FreeBSD_kernel__. Use the alternative when the functionality tested is for kernel features, and keep the __FreeBSD__ one when using freebsd libc headers. If this patch is applied, debian could drop all the current patches when importing 6.0 :)
2014-12-01Update Ukrainian translationYuri Chornoivan1-399/+290
2014-12-01Updated Polish translationPiotr Drąg1-517/+394
2014-11-24build-sys: Fix the BlueZ 5 native headset backend checkTanu Kaskinen1-4/+4
If the libbluetooth headers aren't available, we shouldn't treat that as an error unless --enable-bluez5-native-headset has been explicitly given to configure. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=86582
2014-11-24build-sys: Always define bluetooth related HAVE_* variablesTanu Kaskinen1-5/+9
I don't know if it can cause any problems if HAVE_BLUEZ_4, HAVE_BLUEZ_5, HAVE_BLUEZ, HAVE_BLUEZ_5_OFONO_HEADSET or HAVE_BLUEZ_5_NATIVE_HEADSET are undefined when the corresponding features are not enabled, but it certainly won't hurt to define the variables also when the features are not enabled.
2014-11-24NEWS: Zsh completion support isn't new in 6.0Tanu Kaskinen1-1/+0
There have been several fixes to the Zsh completion during the current development cycle, but the completion was initially implemented already in 4.0.
2014-11-23i18n: update Chinese (traditional) translationCheng-Chia Tseng1-222/+92
2014-11-21po: add pulseaudio.service.in to POTFILES.inv5.99.1David Henningsson1-0/+1
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-11-21NEWS: Write entry for 6.0David Henningsson1-0/+61
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-11-21configure: Bump sonamesDavid Henningsson1-1/+1
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-11-21bluetooth: set gain correctlyWim Taymans1-4/+4
Send the right command to set the speaker and microphone gain. Note that setting the volume on the Headset should use the unsolicited result code. Receiving the volume from the Headset uses the AT command.
2014-11-20raop: Fix a memory leakTanu Kaskinen1-2/+7
a.path_or_host wasn't freed after calling pa_parse_address().
2014-11-17alsa-mixer: Use pa_assert_not_reached()Peter Meerwald1-2/+1
get rid of the following warning when compiling with NDEBUG: modules/alsa/alsa-mixer.c: In function 'element_is_subset': modules/alsa/alsa-mixer.c:3125:18: warning: 'a_limit' may be used uninitialized in this function [-Wmaybe-uninitialized] long a_limit; Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
2014-11-17tests: Use pa_assert_se() to get rid of an used variable warningPeter Meerwald1-6/+4
when compiled with NDEBUG Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
2014-11-17core: Annotate variables only used within assert()s to be PA_UNUSEDPeter Meerwald7-10/+10
supresses a warning when compiling with NDEBUG: pulsecore/aupdate.c: In function 'pa_aupdate_read_end': pulsecore/aupdate.c:82:14: warning: variable 'n' set but not used [-Wunused-but-set-variable] unsigned n; pulsecore/sink-input.c: In function 'pa_sink_input_unlink': pulsecore/sink-input.c:648:27: warning: variable 'p' set but not used [-Wunused-but-set-variable] pa_source_output *o, *p = NULL; pulsecore/sink-input.c: In function 'find_filter_sink_input': pulsecore/sink-input.c:1523:14: warning: unused variable 'i' [-Wunused-variable] unsigned i = 0; pulsecore/sink-input.c: In function 'pa_sink_input_start_move': pulsecore/sink-input.c:1569:27: warning: variable 'p' set but not used [-Wunused-but-set-variable] pa_source_output *o, *p = NULL; CC pulsecore/libpulsecore_5.0_la-sink.lo pulsecore/sink.c: In function 'pa_sink_unlink': pulsecore/sink.c:673:24: warning: variable 'j' set but not used [-Wunused-but-set-variable] pa_sink_input *i, *j = NULL; pulsecore/source-output.c: In function 'find_filter_source_output': pulsecore/source-output.c:1179:9: warning: unused variable 'i' [-Wunused-variable] int i = 0; CC pulsecore/libpulsecore_5.0_la-source.lo pulsecore/source.c: In function 'pa_source_unlink': pulsecore/source.c:616:27: warning: variable 'j' set but not used [-Wunused-but-set-variable] pa_source_output *o, *j = NULL; Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
2014-11-17macro: Add macro PA_UNUSEDPeter Meerwald1-0/+6
the macro PA_UNUSED may be used to suppress a warning when a variable is not used, or assigned and never used; this typically happens when the only use of the variable is within an assert() that can be optimized away (i.e. with NDEBUG set) has an effect with GCC only v2: (thanks to Alexander Patrakov) * fix patch subject/description Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
2014-11-17macro: Abort() when pa_assert_not_reached() even for NDEBUGPeter Meerwald1-1/+1
fixes many warnings when compiling with NDEBUG, such as CC pulse/libpulse_la-channelmap.lo pulse/channelmap.c: In function 'pa_channel_map_init_auto': pulse/channelmap.c:397:1: warning: control reaches end of non-void function [-Wreturn-type] Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
2014-11-17build-sys: Deprecate libsamplerate supportPeter Meerwald2-1/+7
output DEPRECATED warnings for libsamplerate in configure and PA daemon's log libsamplerate offers no particular advantage over the speex resampler and is distributed under GPL; support for it will be removed in one of the next releases v2: (thanks Arun Raghavan) * log a warning (instead of info) Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
2014-11-17alsa-util: Finish description of pa_alsa_set_hw_params()Peter Meerwald1-2/+3
... which stops mid-sentence and logging cleanup Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
2014-11-17dbus-iface: Initialize "new_active" variable to NULLDavid Henningsson1-1/+1
Fixes warning: 'new_active' may be used uninitialized in this function, and could potentially cause erronous behaviour in case an invalid port name was specified. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-11-17Alsa: Correct port availability with multiple jacksSjoerd Simons1-7/+18
In case there are two independent jacks for one port (e.g. Dock Headphone Jack and Headphone Jack), the availability ends up being incorrect if the first one was _NO (not plugged) and the second gets _YES (plugged). Also pulse complains about the state being inconsistent which isn't true. Fix this by preferring more precise states (yes/no) over unknown and yes over others. However in case a plugged jack makes the port unavailable let that overrule everything else.
2014-11-14dbus: Fix the ActivePort property handlerTanu Kaskinen1-1/+10
The old code tried to look up the port object by using an object path, but the ports hashmap uses port names as keys, so the method failed always. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=85369
2014-11-14shell-completion: zsh: Fix the set-card-profile descriptionTanu Kaskinen1-1/+1
2014-11-14shell-completion: zsh: Fix set-default-sink/source completionTanu Kaskinen1-0/+2
The _devices() function didn't recognize the set-default-* commands, and as a result it didn't generate any completions.
2014-11-14bluetooth: Select headset backend through module argumentDavid Henningsson4-6/+55
This patch adds a module argument "headset=ofono|native|auto" to module-bluetooth-discover and module-bluez5-discover. To make Arun's happy, the default is 'native' if compiled in, otherwise 'ofono'. 'Auto' will try to autoswitch depending on whether ofono is running or not. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-11-14bluez 5: remove null headset backendDavid Henningsson1-37/+0
There is no need to have a "null" backend anymore. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-11-14bluez 5: Fix a debug messageDavid Henningsson1-1/+1
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-11-14bluez 5: Load the native headset backend if the oFono one is unavailableDavid Henningsson3-11/+28
This implements some autodetect if both headset backends are compiled in: First we try to contact the oFono service, if that's not working, then we start the native backend instead. Likewise if the oFono service is going offline/online, we load/unload the native backend accordingly. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-11-14bluez 5: Build both headset backends, if availableDavid Henningsson6-29/+69
Enable both ofono and native backends to be built into the same libbluez5-util. Never build the null backend. Signed-off-by: David Henningsson <david.henningsson@canonical.com>
2014-11-12resampler: Fix sample_format_more_precise() for the case of comparing ↵Andrey Semashev1-1/+1
against PA_SAMPLE_S32BE Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
2014-11-12.gitignore: Add pulseaudio.serviceTanu Kaskinen1-0/+1
2014-11-12build-sys: Fix a variable value checkTanu Kaskinen1-1/+1
2014-11-10build-sys: Fix daemon linking when building with systemd-daemon supportMauro Guerrera1-0/+5
Seems that after commit 467b4b9be systemd usage has been added into src/daemon/main.c but there is no link for the corresponding library in the final pulseaudio binary. This might be missed in some build systemd due to overlinking, but it's correct to add this in here explicitly Signed-off-by: Colin Guthrie <colin@mageia.org>
2014-11-10rtpoll: Fixup pa_rtpoll_runDavid Henningsson6-6/+6
Commit fa092af59cf64902a5caa99 removed an argument to pa_rtpoll_run, but forgot to remove that argument for all callers to pa_rtpoll_run. This commit removes the remaining ones. Signed-off-by: David Henningsson <david.henningsson@canonical.com>