diff options
| -rw-r--r-- | ChangeLog | 6 | ||||
| -rw-r--r-- | ext/taglib/gstid3v2mux.cc | 11 |
2 files changed, 16 insertions, 1 deletions
@@ -1,5 +1,11 @@ 2007-11-14 Tim-Philipp Müller <tim at centricular dot net> + * ext/taglib/gstid3v2mux.cc: (add_musicbrainz_tag), (add_funcs): + Write GST_TAG_MUSICBRAINZ_DISCID and GST_TAG_CDDA_CDDB_DISCID + into ID3v2 TXXX frames (fixes #347848). + +2007-11-14 Tim-Philipp Müller <tim at centricular dot net> + * gst/rtsp/gstrtspsrc.c: (gst_rtspsrc_open): Don't leak sdp message contents (fixes #496773). diff --git a/ext/taglib/gstid3v2mux.cc b/ext/taglib/gstid3v2mux.cc index c799feb99..cf1762797 100644 --- a/ext/taglib/gstid3v2mux.cc +++ b/ext/taglib/gstid3v2mux.cc @@ -321,7 +321,14 @@ add_musicbrainz_tag (ID3v2::Tag * id3v2tag, const GstTagList * list, GST_TAG_MUSICBRAINZ_ALBUMID, "MusicBrainz Album Id", "musicbrainz_albumid"}, { GST_TAG_MUSICBRAINZ_ALBUMARTISTID, "MusicBrainz Album Artist Id", "musicbrainz_albumartistid"}, { - GST_TAG_MUSICBRAINZ_TRMID, "MusicBrainz TRM Id", "musicbrainz_trmid"} + GST_TAG_MUSICBRAINZ_TRMID, "MusicBrainz TRM Id", "musicbrainz_trmid"}, { + GST_TAG_CDDA_MUSICBRAINZ_DISCID, "MusicBrainz DiscID", + "musicbrainz_discid"}, { + /* the following one is more or less made up, there seems to be little + * evidence that any popular application is actually putting this info + * into TXXX frames; the first one comes from a musicbrainz wiki 'proposed + * tags' page, the second one is analogue to the vorbis/ape/flac tag. */ + GST_TAG_CDDA_CDDB_DISCID, "CDDB DiscID", "discid"} }; guint i, idx; @@ -584,6 +591,8 @@ static const struct GST_TAG_MUSICBRAINZ_ALBUMID, add_musicbrainz_tag, "\001"}, { GST_TAG_MUSICBRAINZ_ALBUMARTISTID, add_musicbrainz_tag, "\002"}, { GST_TAG_MUSICBRAINZ_TRMID, add_musicbrainz_tag, "\003"}, { + GST_TAG_CDDA_MUSICBRAINZ_DISCID, add_musicbrainz_tag, "\004"}, { + GST_TAG_CDDA_CDDB_DISCID, add_musicbrainz_tag, "\005"}, { GST_TAG_MUSICBRAINZ_TRACKID, add_unique_file_id_tag, ""}, { GST_TAG_ARTIST_SORTNAME, add_text_tag, "TSOP"}, { GST_TAG_ALBUM_SORTNAME, add_text_tag, "TSOA"}, { |