Xi: check for Use permission on the device in SetClientPointer().

Presumably, some intelligent, XI2-aware management app will be calling
XISetClientPointer on behalf of other clients; this check makes sure
the target client has permission on the device.

Requires changing the prototype to return status code instead of Bool.

Signed-off-by: Eamon Walsh <ewalsh@tycho.nsa.gov>
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>

1 files changed, 3 insertions, 2 deletions

diff --git a/Xi/xisetclientpointer.c b/Xi/xisetclientpointer.c
index 273618503..09db8ff75 100644
--- a/Xi/xisetclientpointer.c
+++ b/Xi/xisetclientpointer.c
@@ -98,10 +98,11 @@ ProcXISetClientPointer(ClientPtr client)
     } else
         targetClient = client;
 
-    if (!SetClientPointer(targetClient, pDev))
+    rc = SetClientPointer(targetClient, pDev);
+    if (rc != Success)
     {
         client->errorValue = stuff->deviceid;
-        return BadDevice;
+        return rc;
     }
 
     return Success;