diff options
| author | Lucas De Marchi <lucas.demarchi@intel.com> | 2024-03-13 12:34:41 -0700 |
|---|---|---|
| committer | Lucas De Marchi <lucas.demarchi@intel.com> | 2024-03-14 06:30:58 -0700 |
| commit | 93ad5b785ea04400796d2b68effdeae2e02b5a64 (patch) | |
| tree | 7427ee467dc2521dbbe1f7de0960e7c3e7c8cede /lib/igt_kmod.h | |
| parent | c62f9ce053dbdfe1c5899c417497c52b7594dcad (diff) | |
lib/igt_kmod: stop using KMOD_REMOVE_FORCE
The flag to force remove a module should never be used. The flag is
intended for end users to decide if they want to have a broken system
left after that. Maybe it's a "controlled breakage". It's not something
for a testsuite to use.
If the kernel ever resorts to honoring the flag (due to module's kref
not being 0), we will have a tainted kernel, potential leaks and memory
corruption. It's better to just handle the error returned by libkmod and
fix the root cause.
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Diffstat (limited to 'lib/igt_kmod.h')
| -rw-r--r-- | lib/igt_kmod.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/igt_kmod.h b/lib/igt_kmod.h index 990e5309d..efb46da12 100644 --- a/lib/igt_kmod.h +++ b/lib/igt_kmod.h @@ -34,7 +34,7 @@ void igt_kmod_list_loaded(void); bool igt_kmod_has_param(const char *mod_name, const char *param); int igt_kmod_load(const char *mod_name, const char *opts); -int igt_kmod_unload(const char *mod_name, unsigned int flags); +int igt_kmod_unload(const char *mod_name); int igt_audio_driver_unload(char **whom); |