diff options
| author | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2023-03-31 21:51:12 +0300 |
|---|---|---|
| committer | Ville Syrjälä <ville.syrjala@linux.intel.com> | 2023-04-07 02:48:19 +0300 |
| commit | 0a757a780439637d094964a8630a7ef8d8205004 (patch) | |
| tree | fa5ea5ca0b9bb434f3fc0e39d2b634442e5d63d4 /lib/i915 | |
| parent | 402a13477510ab05591839a2bf4586de1158e60c (diff) | |
lib/i915/perf: Stop generating silly C code
Seems a bit weird to use use python to generate C code that
generates arrays of registers. Just generate those arrays
straight from python.
$ size -A meson-generated_.._i915_perf_registers_acmgt3.c
-.text 1737442 0
+.text 257871 0
+.rodata 820776 0
$ du -h build/lib/libi915_perf.so.1.5
- 23M build/lib/libi915_perf.so.1.5
+ 19M build/lib/libi915_perf.so.1.5
And the change in build time:
$ touch lib/i915/perf-configs/perf-registers-codegen.py
$ time ninja -C build -j1
ADL:
- real 2m32,251s
+ real 1m8,984s
VLV:
- real 19m14.999s
+ real 8m3.277s
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Diffstat (limited to 'lib/i915')
| -rw-r--r-- | lib/i915/perf-configs/perf-registers-codegen.py | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/lib/i915/perf-configs/perf-registers-codegen.py b/lib/i915/perf-configs/perf-registers-codegen.py index 19f09d7a8..bde3d1432 100644 --- a/lib/i915/perf-configs/perf-registers-codegen.py +++ b/lib/i915/perf-configs/perf-registers-codegen.py @@ -68,9 +68,19 @@ def generate_register_configs(set): set.gen.output_availability(set, availability, register_config.get('type') + ' register config') c.indent(4) + c("{") + c.indent(4) + c("static const struct intel_perf_register_prog _%s[] = {" % t) + c.indent(4) for register in register_config.findall('register'): - c("metric_set->%s[metric_set->n_%s++] = (struct intel_perf_register_prog) { .reg = %s, .val = %s };" % - (t, t, register.get('address'), register.get('value'))) + c("{ .reg = %s, .val = %s }," % + (register.get('address'), register.get('value'))) + c.outdent(4) + c("};") + c("memcpy(metric_set->%s, _%s, sizeof(_%s));" % (t, t, t)) + c("metric_set->n_%s = sizeof(_%s) / sizeof(_%s[0]);" % (t, t, t)) + c.outdent(4) + c("}") if availability: c.outdent(4) @@ -146,6 +156,7 @@ def main(): c(copyright) c("\n") c("#include <stdlib.h>") + c("#include <string.h>") c("\n") c("#include \"%s\"" % header_file) c("#include \"i915/perf.h\"") |