summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2012-05-17ssl-verify: add a bit of run-time checksHEADmasterMarc-André Lureau1-0/+5
Even if they are not public functions, those conditions can be reached in a invalid state.
2012-05-02video streaming: add support for frames of different sizesYonit Halperin4-6/+36
rhbz #813826, #815426 Add SPICE_MSG_DISPLAY_STREAM_DATA_SIZED, for stream_data message that also contains the size and destination box of the data. The server can send such messages only to clients with SPICE_DISPLAY_CAP_SIZED_STREAM.
2012-05-02region: add region_extentsYonit Halperin2-0/+13
2012-05-02rect: add rect_debugYonit Halperin1-0/+11
2012-05-02rect: add rect_get_areaYonit Halperin1-0/+10
2012-05-02rect: add rect_containsYonit Halperin1-0/+11
2012-04-26Set the clip type to reflect the on wire type.Jeremy White1-1/+1
2012-04-25Add missing struct field initializersDaniel P. Berrange2-4/+6
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2012-04-18move variable decleration to head of code blockAric Stewart1-1/+1
Signed-off-by: Aric Stewart <aric@codeweavers.com>
2012-04-18allow log.c to compile under MSVC++Aric Stewart1-0/+12
2012-04-18add padding member to SpiceMsgEmptyAric Stewart1-0/+1
Empty structures are undefined in C, gcc handles them without issue assigning a size of 0. However MSVC++ generates a hard error (C2015) this allows messages.h to be included in c files compiled by MSVC++. Signed-off-by: Aric Stewart <aric@codeweavers.com>
2012-04-17Add a return value to the default case in create_bitmap to satisfy VC++Aric Stewart1-1/+1
2012-04-06demarshall: add missing parens in BE read_xxx functionsChristophe Fergeau1-1/+1
The missing parens causes build to fail on big-endian machines
2012-04-04Update spice-protocol submoduleChristophe Fergeau1-0/+0
We need the USB redirection controller messages
2012-04-03configure.ac: lower required autoconf version to 2.63Hans de Goede1-1/+1
So that one can autogen.sh on RHEL-6. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
2012-04-03update submodule spice-protocolYonit Halperin1-0/+0
added the disable-effects and color-depth options to the controller Signed-off-by: Yonit Halperin <yhalperi@redhat.com>
2012-03-30Bypass certicate verification failure if PUBKEY check onlyMarc-André Lureau1-0/+7
During switch-host migration, only PUBKEY verification is required. Couldn't it just load the certificate again for the new session? perhaps, but that's they way the code used to work until I introduced a regression in spice commit d46f9d3f4e006d3bca9b99fac25169b17e7ac803.
2012-03-30ssl-verify: improve logging report in case of errorsMarc-André Lureau1-30/+40
Use the log.h system, and report a bit more information in the debug level
2012-03-28Fix harmless warnings in quic_encode()Marc-André Lureau1-3/+3
The quic code has been changed recently this way: - ASSERT(encoder->usr, line); + if (line == NULL) { + spice_warn_if_reached(); + return QUIC_ERROR; + } It appears that the only caller of quic_encode() gives a NULL line and rely on the more_lines() callback to return new lines instead. Adjust the code accordingly, adding a few more checks to verify the caller gives/returns correct values.
2012-03-25build-sys: split client marshallers in seperate libMarc-André Lureau1-13/+16
2012-03-22build-sys: make it a seperately buildable spice-common libraryMarc-André Lureau16-29/+644
- autotoolize - fix headers inclusion - generate gitignores - workaround serverSMARTCARD support with dirty hack...
2012-03-21spice.proto: fix demarshaller crash with name messageMarc-André Lureau1-1/+1
It turned out the demarshaller wasn't allocating enough space to memcpy the name. In order to take into account the size of a variable array, it needs to be marked with the @end tag so that the "extra_size" is added to the allocated memory. It would be nice if the demarshaller would somehow fail if this wasn't set explicitly, or do the right thing by default. @end the name so that demarshaller
2012-03-21codegen: ifdef/endif function declaration tooMarc-André Lureau1-0/+2
Compile out part that we are not supporting. In the future, we might want to declare a fake type and an empty function to keep API compatibility
2012-03-21codegen: include headers locallyMarc-André Lureau2-2/+3
2012-03-21codegen: struct marshallers are not current function helperMarc-André Lureau2-3/+4
This solves the issue of struct_marshallers being included within the current ifdef/endif body, although they are independant functions.
2012-03-20use new @ifdef directive for smartcard messagesChristophe Fergeau1-1/+1
We don't want to conditionally compile the smartcard messages depending on whether USE_SMARTCARD is set or not, we can now use the @ifdef attribute for that.
2012-03-20add smartcard bits to spice.protoChristophe Fergeau1-4/+73
2012-03-20spice_codegen: Always write a channels entry for an ifdef-ed channelHans de Goede2-0/+11
Before this patch, if a channel is defined conditionally in spice.proto (because it depends on external headers like the smartcard channel), spice_codegen would write an entry to the channels array in spice_get_*_channel_parser which would only take up a place in the array if the ifdef condition is true, thus moving up all other intializers one place when it is not true. This was causing issues (crashes) when building spice-gtk with the combination of usbredir support enabled and smartcard support disabled. This patch fixes this by adding #else { NULL, 0 }, to the generated code. Thanks to coolper chen <lixin.chen@saicocch.com> for reporting this! Signed-off-by: Hans de Goede <hdegoede@redhat.com>
2012-03-20handle @ifdef on messages and channelsChristophe Fergeau2-7/+43
2012-03-20allow attributes on channel elements in .proto filesChristophe Fergeau2-2/+4
We want to be able to add an @ifdef annotation to optional messages For example, we want to compile in the smartcard messages only if libcacard is available
2012-03-20add ifdef/endif methods to spice code generatorChristophe Fergeau1-0/+12
These methods will be needed to be able to make some fields optional in spice.proto
2012-03-20fix copy & paste error in ptypes.pyChristophe Fergeau1-3/+1
2012-03-20Add SPICE_ATTR_NORETURN and use it for a few functionsMarc-André Lureau2-1/+10
2012-03-20Fix build with SPICE_DISABLE_ABORTMarc-André Lureau1-0/+1
2012-03-20Remove need for SPICE_CANVAS_INTERNALMarc-André Lureau8-32/+0
Why is this useful?
2012-03-20fix void* arithmeticMarc-André Lureau1-1/+1
marshaller.c:528:50: error: pointer of type 'void *' used in arithmetic [-Werror=pointer-arith]
2012-03-20build: replace INCLUDES with AM_CPPFLAGSMarc-André Lureau1-1/+1
Fix warning `INCLUDES' is the old name for `AM_CPPFLAGS' (or `*_CPPFLAGS')
2012-03-20Add missing includes & make some functions staticDaniel P. Berrange2-3/+3
A number of functions were used without prior declaration. In some cases this was due to missing include files. In other cases the functions should have just been static. Ideally this would allow -Wmissing-declarations to be enabled, but the files generated by spice_codegen.py will still trip up on this.
2012-03-20Add printf format annotations to all '...' functionsDaniel P. Berrange6-14/+16
To allow the compile to detect incorrect printf formats, any var-args function should have a format annotation * common/macros.h: Helper to define ATTR_PRINTF for code which can't depend on glib * common/canvas_base.c, common/lz.h, common/macros.h: Annotate some var-args methods
2012-03-20Fix some integer range checks which always evaluate falseDaniel P. Berrange1-2/+2
There are some integer range checks which always evaluate false due to use of unsigned integer types. One of these would prevent detection of encoding errors from celt. The others are simply no-ops. * common/pixman_utils.c: SpiceROP is an enum & thus unsigned
2012-03-20Avoid warnings about empty conditional statement bodiesDaniel P. Berrange1-6/+9
Add extra {} braces around if/else statements which only call SPICE_DEBUG to avoid: ../common/ssl_verify.c: In function 'verify_pubkey': ../common/ssl_verify.c:87:50: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] ../common/ssl_verify.c: In function 'verify_hostname': ../common/ssl_verify.c:254:53: warning: suggest braces around empty body in an 'if' statement [-Wempty-body] ../common/ssl_verify.c: In function 'verify_subject': ../common/ssl_verify.c:381:41: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
2012-03-20build: remove 'win' directoryMarc-André Lureau13-1643/+0
Let's use the only included file directly instead.
2012-03-20messages.h: add smartcard bitsChristophe Fergeau1-0/+22
2012-03-20Add client_marshallers.h client_demarshallers.h from spice-gtkMarc-André Lureau3-0/+104
spice-gtk uses a more up to date version of client/marshallers.h and client/demarshallers.h
2012-03-20Use SPICE_{BEGIN,END}_DECLSMarc-André Lureau25-154/+93
2012-03-20add const to arrays in marshalling functionsChristophe Fergeau2-2/+2
2012-03-20ssl_verify: include <string.h>Christophe Fergeau1-0/+1
ssl_verify.c is using memcmp which comes from string.h, this was breaking compilation with -Werror -Wall on Mac OS X
2012-03-20ssl_verify: comment X509_NAME undefMarc-André Lureau1-0/+3
2012-03-20Use a log handler to modify abort() behaviourMarc-André Lureau28-553/+820
Be more library friendly, by not aborting in library errors. spice_common now includes a proper log handler that will abort by default when reaching a warning. SPICE_ABORT_LEVEL can be changed to modify run-time abort level. SPICE_DEBUG_LEVEL can be changed to be more verbose. By default, only log level more importants than WARNING. Only memory-related functions are allowed to abort(), since they are not recoverable errors in the library.
2012-03-20update gitignoreMarc-André Lureau1-0/+3