diff options
| author | Eric Anholt <eric@anholt.net> | 2010-03-02 15:05:30 -0800 |
|---|---|---|
| committer | Eric Anholt <eric@anholt.net> | 2010-03-02 15:39:37 -0800 |
| commit | a0abb1b14ef60abfd1d5aacd83f06d6f94dc13a4 (patch) | |
| tree | cbeb172e3039d87383efa6847a487e1d7b213bd5 /intel | |
| parent | cdc788d6456645072a1610aa9217e4ebae5cfc6b (diff) | |
intel: add a comment about tiled buffer alloc height alignment from Mesa.
Diffstat (limited to 'intel')
| -rw-r--r-- | intel/intel_bufmgr_gem.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c index ea766782..c4ec6214 100644 --- a/intel/intel_bufmgr_gem.c +++ b/intel/intel_bufmgr_gem.c @@ -680,6 +680,17 @@ drm_intel_gem_bo_alloc_tiled(drm_intel_bufmgr *bufmgr, const char *name, unsigned long size, stride, aligned_y = y; int ret; + /* If we're tiled, our allocations are in 8 or 32-row blocks, + * so failure to align our height means that we won't allocate + * enough pages. + * + * If we're untiled, we still have to align to 2 rows high + * because the data port accesses 2x2 blocks even if the + * bottom row isn't to be rendered, so failure to align means + * we could walk off the end of the GTT and fault. This is + * documented on 965, and may be the case on older chipsets + * too so we try to be careful. + */ if (*tiling_mode == I915_TILING_NONE) aligned_y = ALIGN(y, 2); else if (*tiling_mode == I915_TILING_X) |