Results parser: Handle errors parsing lines more properly

Use a better error message to help debug what is going on.  I don't see
how that regex could fail off the top of my head, even an empty string should
match and return '' and '' for the groups.

(update: What we're seeing after this is that somehow the parser is getting a "line" that contains newlines at times; not sure how)

Signed-off-by: Gregory Smith <gps@google.com>


git-svn-id: svn://test.kernel.org/autotest/trunk@5274 592f7852-d20e-0410-864c-8624ca9c26a4

1 files changed, 7 insertions, 1 deletions

diff --git a/tko/parsers/version_0.py b/tko/parsers/version_0.py
index 7e8a5d88..c690d211 100644
--- a/tko/parsers/version_0.py
+++ b/tko/parsers/version_0.py
@@ -251,7 +251,13 @@ class status_line(object):
     def parse_line(cls, line):
         if not status_line.is_status_line(line):
             return None
-        indent, line = re.search(r"^(\t*)(.*)$", line).groups()
+        match = re.search(r"^(\t*)(.*)$", line)
+        if not match:
+            # A more useful error message than:
+            #  AttributeError: 'NoneType' object has no attribute 'groups'
+            # to help us debug WTF happens on occasion here.
+            raise RuntimeError("line %r could not be parsed." % line)
+        indent, line = match.groups()
         indent = len(indent)
 
         # split the line into the fixed and optional fields