diff options
| author | Alan Coopersmith <alan.coopersmith@oracle.com> | 2014-09-04 23:18:03 -0700 |
|---|---|---|
| committer | Keith Packard <keithp@keithp.com> | 2014-09-11 18:25:42 -0700 |
| commit | 8f8dcfee2085ba82107a8bf3872a0bb241493409 (patch) | |
| tree | f2bcf01d6fdbd2fb120b2ff7e4c4b5de1a6a98b5 /present | |
| parent | d0da0e9c3bb8fe0cd4879ecb24d21715bfaa209b (diff) | |
Make list tests actually test lists
Coverity scan detected that asserts were setting values, not checking them:
CID 53252: Side effect in assertion (ASSERT_SIDE_EFFECT)
assignment_where_comparison_intended: Assignment item->b = i * 2
has a side effect. This code will work differently in a non-debug build.
Did you intend to use a comparison ("==") instead?
CID 53259: Side effect in assertion (ASSERT_SIDE_EFFECT)
assignment_where_comparison_intended: Assignment item->a = i
has a side effect. This code will work differently in a non-debug build.
Did you intend to use a comparison ("==") instead?
CID 53260: Side effect in assertion (ASSERT_SIDE_EFFECT)
assignment_where_comparison_intended: Assignment item->a = i
has a side effect. This code will work differently in a non-debug build.
Did you intend to use a comparison ("==") instead?
CID 53261: Side effect in assertion (ASSERT_SIDE_EFFECT)
assignment_where_comparison_intended: Assignment item->b = i * 2
has a side effect. This code will work differently in a non-debug build.
Did you intend to use a comparison ("==") instead?
Fixing those to be == caused test_nt_list_insert to start failing as
part assumed append order, part assumed insert order, so it had to be
fixed to use consistent ordering.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Keith Packard <keithp@keithp.com>
Diffstat (limited to 'present')
0 files changed, 0 insertions, 0 deletions