diff options
| author | Tero Kristo <t-kristo@ti.com> | 2016-04-18 14:49:53 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2016-04-18 18:13:24 +0100 |
| commit | 07c5c3ad98926dc15d31aa86de62fd4170f2a745 (patch) | |
| tree | 2befea4802027583d75eab9cb5837675ee2b5e44 /drivers/regulator | |
| parent | 9d2597e8c4e593e4a4dbe70837e9396e53a2665a (diff) | |
regulator: core: remove lockdep assert from suspend_prepare
suspend_prepare can be called during regulator init time also, where
the mutex is not locked yet. This causes a false lockdep warning.
To avoid the problem, remove the lockdep assertion from the function
causing the issue. An alternative would be to lock the mutex during
init, but this would cause other problems (some APIs used during init
will attempt to lock the mutex also, causing deadlock.)
Signed-off-by: Tero Kristo <t-kristo@ti.com>
Reported-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator')
| -rw-r--r-- | drivers/regulator/core.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 6dd63523bcfe..f28fca4b68e3 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -808,8 +808,6 @@ static int suspend_set_state(struct regulator_dev *rdev, /* locks held by caller */ static int suspend_prepare(struct regulator_dev *rdev, suspend_state_t state) { - lockdep_assert_held_once(&rdev->mutex); - if (!rdev->constraints) return -EINVAL; |