diff options
| author | Daniel Stone <daniels@collabora.com> | 2016-02-12 16:36:59 +0000 |
|---|---|---|
| committer | Adam Jackson <ajax@redhat.com> | 2016-02-22 13:26:31 -0500 |
| commit | e957a2e5dd288f515f3e93724823542c20333f6a (patch) | |
| tree | 0f0e885f72fe0dcf9a13531adf6fcdd28a121a1f /hw/xwin | |
| parent | dbe8d03c42f01332b3dc41fe9290aed142f1436f (diff) | |
dix: Add hybrid full-size/empty-clip mode to SetRootClip
216bdbc735 removed the SetRootClip call in the XWayland output-hotplug
handler when running rootless (e.g. as a part of Weston/Mutter), since
the root window has no storage, so generating exposures will result in
writes to invalid memory.
Unfortunately, preventing the segfault also breaks sprite confinement.
SetRootClip updates winSize and borderSize for the root window, which
when combined with RRScreenSizeChanged calling ScreenRestructured,
generates a new sprite-confinment area to update it to the whole screen.
Removing this call results in the window geometry being reported
correctly, but winSize/borderSize never changing from their values at
startup, i.e. out of sync with the root window geometry / screen
information in the connection info / XRandR.
This patch introduces a hybrid mode, where we update winSize and
borderSize for the root window, enabling sprite confinement to work
correctly, but keep the clip emptied so exposures are never generated.
Signed-off-by: Daniel Stone <daniels@collabora.com>
Tested-by: Olivier Fourdan <ofourdan@redhat.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Diffstat (limited to 'hw/xwin')
| -rw-r--r-- | hw/xwin/winrandr.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/xwin/winrandr.c b/hw/xwin/winrandr.c index f4ba054bc..c29d7b37a 100644 --- a/hw/xwin/winrandr.c +++ b/hw/xwin/winrandr.c @@ -75,7 +75,7 @@ winDoRandRScreenSetSize(ScreenPtr pScreen, WindowPtr pRoot = pScreen->root; // Prevent screen updates while we change things around - SetRootClip(pScreen, FALSE); + SetRootClip(pScreen, ROOT_CLIP_NONE); /* Update the screen size as requested */ pScreenInfo->dwWidth = width; @@ -101,7 +101,7 @@ winDoRandRScreenSetSize(ScreenPtr pScreen, // does this emit a ConfigureNotify?? // Restore the ability to update screen, now with new dimensions - SetRootClip(pScreen, TRUE); + SetRootClip(pScreen, ROOT_CLIP_FULL); // and arrange for it to be repainted pScreen->PaintWindow(pRoot, &pRoot->borderClip, PW_BACKGROUND); |