summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Coopersmith <alan.coopersmith@oracle.com>2011-04-19 18:53:22 -0700
committerAlan Coopersmith <alan.coopersmith@oracle.com>2011-05-02 20:38:03 -0700
commitdadb0791ebfd05cd3bb82d4addf0fbc21aad6fbb (patch)
tree2fb9ef7cf5672bb31f34e6996da0e62ee83a56eb
parent8d229c4cf9e5bde78373ef3dd32708817ac97152 (diff)
Only free pContext once when AddResource fails in ProcRecordCreateContext
Since RecordDeleteContext frees its argument, don't fall through to free it again. Error: Double free (CWE 415) Double free of pointer 'malloc(1072)' defined by malloc at line 1964 of record/record.c in function 'ProcRecordCreateContext'. Previously freed at line 1960 with RecordDeleteContext. 'malloc(1072)' was allocated at line 1926 with malloc. [ This bug was found by the Parfait 0.3.7 bug checking tool. For more information see http://labs.oracle.com/projects/parfait/ ] Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
-rw-r--r--record/record.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/record/record.c b/record/record.c
index 53be1823f..69fca727e 100644
--- a/record/record.c
+++ b/record/record.c
@@ -1958,7 +1958,7 @@ ProcRecordCreateContext(ClientPtr client)
else
{
RecordDeleteContext((pointer)pContext, pContext->id);
- err = BadAlloc;
+ return BadAlloc;
}
bailout:
free(pContext);