diff options
| author | Konstantin Kharlamov <Hi-Angel@yandex.ru> | 2019-03-24 01:48:39 +0300 |
|---|---|---|
| committer | Alan Coopersmith <alan.coopersmith@oracle.com> | 2022-04-02 18:06:30 +0000 |
| commit | cd0d4c1bb54b809100444e6efc1f161054c43a8b (patch) | |
| tree | 73e888429f0759ef0f698fc6f03f830274424699 | |
| parent | 1d80db55ddfa45edc7fae39b3c9382d7b60f8f72 (diff) | |
xfree86: numTimings is never value other than 0
Correctness is ensured be checking md5sum result before and after the
commit (it's the same).
Fixes LGTM warning "Comparison is always false because numTimings <= 0."
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
| -rw-r--r-- | hw/xfree86/common/xf86Mode.c | 18 |
1 files changed, 4 insertions, 14 deletions
diff --git a/hw/xfree86/common/xf86Mode.c b/hw/xfree86/common/xf86Mode.c index eb0885571..4a0623c49 100644 --- a/hw/xfree86/common/xf86Mode.c +++ b/hw/xfree86/common/xf86Mode.c @@ -1352,8 +1352,7 @@ xf86ValidateModes(ScrnInfoPtr scrp, DisplayModePtr availModes, int saveType; PixmapFormatRec *BankFormat; ClockRangePtr cp; - int numTimings = 0; - range hsync[MAX_HSYNC]; + const int numTimings = 0; range vrefresh[MAX_VREFRESH]; Bool inferred_virtual = FALSE; @@ -1394,18 +1393,9 @@ xf86ValidateModes(ScrnInfoPtr scrp, DisplayModePtr availModes, Bool specified = FALSE; if (scrp->monitor->nHsync <= 0) { - if (numTimings > 0) { - scrp->monitor->nHsync = numTimings; - for (i = 0; i < numTimings; i++) { - scrp->monitor->hsync[i].lo = hsync[i].lo; - scrp->monitor->hsync[i].hi = hsync[i].hi; - } - } - else { - scrp->monitor->hsync[0].lo = 31.5; - scrp->monitor->hsync[0].hi = 48.0; - scrp->monitor->nHsync = 1; - } + scrp->monitor->hsync[0].lo = 31.5; + scrp->monitor->hsync[0].hi = 48.0; + scrp->monitor->nHsync = 1; type = "default "; } else { |