Coverity #544: File a file descriptor leak.XORG-7_0_99_901

2 files changed, 8 insertions, 1 deletions

diff --git a/ChangeLog b/ChangeLog
index d3b2380..254d387 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2006-04-06  Adam Jackson  <ajax@freedesktop.org>
+
+	* src/encparse.c:
+	Coverity #544: File a file descriptor leak.
+
 2005-12-20  Kevin E. Martin  <kem-at-freedesktop-dot-org>
 
 	* configure.ac:
diff --git a/src/encparse.c b/src/encparse.c
index 285f5a1..2263c95 100644
--- a/src/encparse.c
+++ b/src/encparse.c
@@ -867,8 +867,10 @@ FontEncReallyReallyLoad(const char *charset,
         if(!strcasecmp(encoding_name, charset)) {
             /* Found it */
             if(file_name[0] != '/') {
-                if(strlen(dir) + strlen(file_name) >= MAXFONTFILENAMELEN)
+                if(strlen(dir) + strlen(file_name) >= MAXFONTFILENAMELEN) {
+		    fclose(file);
                     return NULL;
+		}
                 strcpy(buf, dir);
                 strcat(buf, file_name);
             } else {