summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-02-09gitlab CI: stop requiring Signed-off-by in commitsHEADmasterAlan Coopersmith1-2/+2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-08-30ico 1.0.6ico-1.0.6Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-08-13Add cast to clear -Wsign-compare warningAlan Coopersmith1-1/+1
ico.c: In function ‘do_ico_window’: ico.c:1084:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (xev.xclient.data.l[0] == wm_delete_window) ^~ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-08-13Rename global "poly" to fix gcc -Wshadow warningsAlan Coopersmith1-5/+5
ico.c: In function ‘initPoly’: ico.c:472:45: warning: declaration of ‘poly’ shadows a global declaration [-Wshadow] initPoly(struct closure *closure, Polyinfo *poly, int icoW, int icoH) ^~~~ ico.c:238:18: note: shadowed declaration is here static Polyinfo *poly; /* -obj: the poly to draw */ ^~~~ ico.c: In function ‘drawPoly’: ico.c:567:45: warning: declaration of ‘poly’ shadows a global declaration [-Wshadow] drawPoly(struct closure *closure, Polyinfo *poly, GC gc, ^~~~ ico.c:238:18: note: shadowed declaration is here static Polyinfo *poly; /* -obj: the poly to draw */ ^~~~ ico.c: In function ‘giveObjHelp’: ico.c:1137:13: warning: declaration of ‘poly’ shadows a global declaration [-Wshadow] Polyinfo *poly = polygons+i; ^~~~ ico.c:238:18: note: shadowed declaration is here static Polyinfo *poly; /* -obj: the poly to draw */ ^~~~ ico.c: In function ‘findpoly’: ico.c:1152:13: warning: declaration of ‘poly’ shadows a global declaration [-Wshadow] Polyinfo *poly = polygons+i; ^~~~ ico.c:238:18: note: shadowed declaration is here static Polyinfo *poly; /* -obj: the poly to draw */ ^~~~ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-08-13Apply scope reduction suggestions from cppcheckAlan Coopersmith1-9/+10
[ico.c:587]: (style) The scope of the variable 'pxvz' can be reduced. [ico.c:730]: (style) The scope of the variable 't' can be reduced. [ico.c:1132]: (style) The scope of the variable 'poly' can be reduced. [ico.c:1149]: (style) The scope of the variable 'poly' can be reduced. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-04-02man page: remove out-of-date COPYRIGHT sectionAlan Coopersmith1-4/+0
The information previously listed here didn't match what is present in the source code or the COPYING file, and the X(7) man page doesn't list any license information as this had claimed. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2021-12-03Build xz tarballs instead of bzip2Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2021-12-03gitlab CI: add a basic build testAlan Coopersmith1-0/+98
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-11-21Update configure.ac bug URL for gitlab migrationAlan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-11-16Update README for gitlab migrationAlan Coopersmith3-28/+22
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-03-09ico 1.0.5ico-1.0.5Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-03-06Fix more sign-compare warningsAlan Coopersmith1-2/+2
ico.c:1136:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i=0; i<NumberPolygons; i++) { ^ ico.c:1151:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i=0; i<NumberPolygons; i++) { ^ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2017-01-26autogen: add default patch prefixMihail Konev1-0/+3
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
2017-01-26autogen.sh: use quoted string variablesEmil Velikov1-4/+4
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2017-01-26autogen.sh: use exec instead of waiting for configure to finishPeter Hutterer1-1/+1
Syncs the invocation of configure with the one from the server. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
2015-04-23Add -version to synopsis in man pageAlan Coopersmith1-1/+7
List -version & -objhelp seperately to indicate they cannot be used with any of the other options. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2015-01-19Convert icoFatal() to be a varargs functionAlan Coopersmith1-10/+13
Drops needless NULL arguments and enables printf format checking. Gets rid of gcc 4.8 warning: ico.c: In function ‘icoFatal’: ico.c:265:2: warning: format not a string literal, argument types not checked [-Wformat-nonliteral] fprintf(stderr, fmt, a0); ^ Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
2014-10-25Make polygon info const - moves 22k from .data to .rodataAlan Coopersmith2-6/+7
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-06-02Add -version option to print program versionAlan Coopersmith2-0/+8
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-06-02Print which option was in error along with usage messageAlan Coopersmith1-0/+2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-06-02Combine usage message array into single stringAlan Coopersmith1-32/+28
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-06-01autogen.sh: Honor NOCONFIGURE=1Alan Coopersmith1-2/+3
See http://people.gnome.org/~walters/docs/build-api.txt Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-06-01configure: Drop AM_MAINTAINER_MODEAlan Coopersmith2-2/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2014-06-01config: Add missing AC_CONFIG_SRCDIRAlan Coopersmith1-2/+5
Regroup AC statements under the Autoconf initialization section. Regroup AM statements under the Automake initialization section. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-01-15ico 1.0.4ico-1.0.4Alan Coopersmith1-1/+1
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-01-03Fix some 64-bit vs. 32-bit conversion errorsAlan Coopersmith1-2/+3
ico.c:851:7: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32] fg = WhitePixel(dpy, DefaultScreen(dpy)); ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ico.c:852:7: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32] bg = BlackPixel(dpy, DefaultScreen(dpy)); ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ico.c:858:18: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32] bg = cdef.pixel; ~ ~~~~~^~~~~ ico.c:866:18: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32] fg = cdef.pixel; ~ ~~~~~^~~~~ ico.c:874:11: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32] bg = tmp; Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2013-01-03Mark a couple parameters as unused to silence compiler warningsAlan Coopersmith2-3/+7
ico.c:436:20: warning: unused parameter 'display' [-Wunused-parameter] predicate(Display *display, XEvent *event, XPointer args) ico.c:511:51: warning: unused parameter 'firsttime' [-Wunused-parameter] setDisplayBuf(struct closure *closure, int n, int firsttime) Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2012-06-05Add const qualifiers to fix gcc -Wwrite-strings warningsAlan Coopersmith1-4/+4
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2011-06-08Replace local checks for gcc with _X_NORETURN from xproto 7.0.17Alan Coopersmith2-6/+5
Also declare icoFatal as static since it's only used in this one file. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by: Mark Kettenis <kettenis@openbsd.org> Reviewed-by: Cyril Brulebois <kibi@debian.org>
2011-01-19config: move man pages into their own directoryGaetan Nadon4-18/+17
Use services provided by XORG_MANPAGE_SECTIONS. Use standard Makefile for man pages. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2011-01-12config: replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERSGaetan Nadon1-1/+1
This silences an Autoconf warning
2010-10-30ico 1.0.3ico-1.0.3Alan Coopersmith1-1/+2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-10-30Purge CVS version tagsAlan Coopersmith3-6/+0
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-10-30config: Remove unnecessary calls from configure.acAlan Coopersmith1-6/+1
AC_PROG_CC & AC_PROG_INSTALL are provided by XORG_DEFAULT_OPTIONS now PKG_CONFIG_MODULES handles AC_SUBST of the CFLAGS & LIBS variables Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-10-30config: upgrade to util-macros 1.8 for additional man page supportAlan Coopersmith2-23/+5
Use MAN_SUBST now supplied in XORG_MANPAGE_SECTIONS The value of MAN_SUBST is the same for all X.Org packages. Use AC_PROG_SED now supplied by XORG_DEFAULT_OPTIONS The existing statement can now be removed from the configuration file. Use automake provided $(AM_V_GEN) and XORG_DEFAULT_OPTIONS provided $(SED) Enables silent rule and use platform appropriate version of sed. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-10-30config: update AC_PREREQ statement to 2.60Gaetan Nadon1-1/+1
Unrelated to the previous patches, the new value simply reflects the reality that the minimum level for autoconf to configure all x.org modules is 2.60 dated June 2006. ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz Signed-off-by: Gaetan Nadon <memsize@videotron.ca> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2010-02-11config: move CWARNFLAGS from configure.ac to Makefile.amGaetan Nadon2-2/+1
Compiler warning flags should be explicitly set in the makefile rather than being merged with other packages compiler flags. Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
2009-11-26Makefile.am: add ChangeLog and INSTALL on MAINTAINERCLEANFILESGaetan Nadon1-0/+1
Now that the INSTALL file is generated. Allows running make maintainer-clean.
2009-10-28INSTALL, NEWS, README or AUTHORS files are missing/incorrect #24206Gaetan Nadon5-3/+6
Add missing INSTALL file. Use standard GNU file on building tarball README may have been updated Remove AUTHORS file as it is empty and no content available yet. Remove NEWS file as it is empty and no content available yet.
2009-10-27Deploy the new XORG_DEFAULT_OPTIONS #24242Gaetan Nadon1-7/+5
This macro aggregate a number of existing macros that sets commmon X.Org components configuration options. It shields the configuration file from future changes.
2009-10-26Makefile.am: ChangeLog not required: EXTRA_DIST or *CLEANFILES #24432Gaetan Nadon1-2/+1
ChangeLog filename is known to Automake and requires no further coding in the makefile.
2009-10-22.gitignore: use common defaults with custom section # 24239Gaetan Nadon1-11/+66
Using common defaults will reduce errors and maintenance. Only the very small or inexistent custom section need periodic maintenance when the structure of the component changes. Do not edit defaults.
2009-10-01Add README with pointers to mailing lists, bugzilla, & gitAlan Coopersmith1-0/+28
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
2009-01-14Correcting a typo in configure.ac preventing the Xorg headers from being foundJens Stroebel1-1/+1
Signed-off-by: Dan Nicholson <dbn.lists@gmail.com>
2009-01-12Ansification and compile warning fixes.Paulo Cesar Pereira de Andrade4-33/+43
This also uses XORG_CHANGELOG and XORG_CWARNFLAGS, corrects make distcheck and all gcc 4.3 and sparse warnings. Note that "ico" appears to be broken, and only work with the -r option, that causes it to not use XThreads, and only draw in the root screen (with "-threads 1" option, the default, it still use XThreads).
2008-10-11Make sure each thread sees its expose event.Keith Packard1-1/+1
Having a thread call XNextEvent may cause other threads to miss their initial expose event, blocking them for a long time. Use the existing predicate function and XIfEvent to wait for precisely the right expose event. Signed-off-by: Keith Packard <keithp@keithp.com>
2007-07-20Version bump: 1.0.2ico-1.0.2Alan Coopersmith1-1/+1
2007-07-20Fill in COPYING stub with copyright & licenses from source filesAlan Coopersmith1-8/+61
2007-07-20Replace static changelog with dist-hook to generate from git logAlan Coopersmith2-36/+9
2007-07-20Change ico_CFLAGS to AM_CFLAGS to stop automake-1.10 warningAlan Coopersmith1-1/+1
Makefile.am:27: compiling `ico.c' with per-target flags requires `AM_PROG_CC_C_O' in `configure.ac'
generated by cgit v1.2.3 (git 2.39.1) at 2024-10-16 08:44:51 +0000