diff options
author | Yong Bakos <ybakos@humanoriented.com> | 2016-04-05 12:02:40 -0500 |
---|---|---|
committer | Bryce Harrington <bryce@bryceharrington.org> | 2016-04-05 15:55:12 -0700 |
commit | 4022eebba7351a37742188d079c7b861fe70187a (patch) | |
tree | bff1faa2130e52dbc46d5d174b36cd8b38e891a7 | |
parent | 8745fe89defbfc4498163d1e9d133cb895af6589 (diff) |
reviewing: Add Reviewed-by reply instructions
Signed-off-by: Yong Bakos <ybakos@humanoriented.com>
Reviewed-by: Bryce Harrington <bryce@osg.samsung.com>
-rw-r--r-- | reviewing.html | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/reviewing.html b/reviewing.html index a664c50..7f8ce3d 100644 --- a/reviewing.html +++ b/reviewing.html @@ -69,8 +69,11 @@ the community. So speak up. <p> Especially, speak up if the patch looks good. If you think it passes the review criteria, <i>say so</i>. Reply to the email saying "This looks good", "Ship -it!" or "Awesome, thanks!" (BTW, praise goes a long way towards making people -feel welcome). +it!" or "Awesome, thanks!" (praise goes a long way towards making people +feel welcome). In addition, add the line <em>Reviewed-by: Real Name +<my@email.address></em> so people pushing patches upstream can make it +<a title="example reviewed commit message" + href="https://cgit.freedesktop.org/wayland/weston/commit/?id=273874e3c715a7102add0030f200d0a0f17628fa">part of the commit message</a>. </p> <p> |