Age | Commit message (Collapse) | Author | Files | Lines |
|
https://bugs.freedesktop.org/show_bug.cgi?id=80803
|
|
|
|
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66085
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Conflicts:
plugins/console/channel.c
|
|
|
|
Simon said:
> + # We only prepare the channel so that ::invalidated will be emitted
> + # when it closes.
>
> Is this really necessary? I would expect that channels would invalidate
> anyway.
And he's right: the channel proxy does invalidate without being prepared
if the connection goes away, or if someone else calls Close() on the
channel.
|
|
As Simon suggested on
<https://bugs.freedesktop.org/show_bug.cgi?id=66085#c1>:
> + /* Not reffing this: the connection owns all channel managers, so it
> + * must outlive us. Taking a reference leads to a cycle.
> + */
> + self->plugin_connection = g_value_get_object (value);
>
> Weak ref, or drop it on DISCONNECTED state?
|
|
|
|
Pretty much all of the 268 lines of channel-manager.c is boilerplate :(
|
|
I was going to complain about how this was worse than just using the raw
D-Bus API via GDBus, but I noticed that the line count went down, so…
|
|
|
|
|
|
I am already losing the will to live at the thought of implementing the
actual requesting and closing bits.
|
|
|
|
|
|
|
|
|
|
The console UI doesn't watch for NameOwnerChanged to notice the
connection going away from beneath it. No big deal, it's a tool for
nerds, but if you tried to quit it, it would not close cleanly: the call
to self.snoopy.teardown() (which tries to turn off the connection
dumping all stanzas over D-Bus) throws an exception, and so
Gtk.main_quit() never got called.
|
|
This breaks the console plugin, which checks if an entered stanza is of
a known type, but <message xmlns=''> is not the same as <message
xmlns='jabber:client'> so Wocky now says the former has type UNKNOWN.
The plugin already had some code to fix up empty namespaces, but it's
after the type check. For a better fix, I added API to give
non-streaming WockyXmppReaders a default namespace, and used it here.
In the course of fixing this, I found that telling the console to send
this:
<message>
<body>
hai
</body>
</message>
would send this:
<message xmlns='jabber:client'>
<body xmlns=''>
hai
</body>
</message>
which is wrong: the empty namespace was not being fixed up recursively.
This is fixed as a side-effect of the default-namespace property, but
this patch also adds a test.
https://bugs.freedesktop.org/show_bug.cgi?id=57016
|
|
Conflicts:
NEWS
configure.ac
src/conn-addressing.c
src/jingle-info.c
src/media-channel-hold.c
src/message-util.c
src/muc-tube-dbus.c
src/muc-tube-stream.c
src/olpc-activity.c
src/presence-cache.c
src/protocol.c
src/room-config.c
|
|
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49384
|
|
Gabble still uses emit_new_channels and tp_handle_{,un}ref, but for
now we can ignore it with this. config.h had to be included in the
right place for a lot of source files.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49596
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
|
|
This lets you configure the plugin directory:
./configure pluginexecdir='${libdir}/my-gabble-plugins'
The directory-name variable has 'exec' in it because Automake installs
unknown directory names with 'exec' in their variable name during
"make install-exec", and other unknown directory names during
"make install-data".
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=46417
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Reviewed-by: Olli Salli <olli.salli@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=46417
|
|
Gabble and Salut Plugin API was updated to remove the dupliate
TpBaseconnection from create_channel_managers. This patch updates
the plugin-base to match the API change
|
|
Using -module doesn't produce .dll files when compiling for windows
These changes enable us to output .dll files for plugins.
https://bugs.freedesktop.org/show_bug.cgi?id=44649
|
|
library
This patch refactors gabble connection by introducing a new GInterface
which the plugins will link agaist. And GabbleConnection implements the
new Interface.
https://bugs.freedesktop.org/show_bug.cgi?id=44649
|
|
All gabble plugins should implement these two methods hereafter.
This patch also updates all the internal plugins to use this new API.
https://bugs.freedesktop.org/show_bug.cgi?id=44331
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=27489
|
|
This reverts commit bf805ba0b2ecced81e5c2830a79d021a42da91a7, reversing
changes made to 1296a2f5ce46e77787ca42eadb1c2ca4a957a09b.
|
|
This reverts commit a687785628216f8f73c699096e9aae4a07b811c6, reversing
changes made to bf805ba0b2ecced81e5c2830a79d021a42da91a7.
|
|
Conflicts:
lib/loudmouth/Makefile.am
plugins/console.c
src/Makefile.am
src/connection.c
src/error.c
src/plugin-loader.c
src/plugin.c
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Conflicts:
lib/loudmouth/Makefile.am
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
Using -module doesn't produce .dll files when compiling for windows
These changes enable us to output .dll files for plugins.
https://bugs.freedesktop.org/show_bug.cgi?id=44649
|
|
library
This patch refactors gabble connection by introducing a new GInterface
which the plugins will link agaist. And GabbleConnection implements the
new Interface.
https://bugs.freedesktop.org/show_bug.cgi?id=44649
|
|
All gabble plugins should implement these two methods hereafter. This patch also updates
all the internal plugins to use this new API
https://bugs.freedesktop.org/show_bug.cgi?id=44331
|
|
All gabble plugins should implement these two methods hereafter. This patch also updates
all the internal plugins to use this new API
https://bugs.freedesktop.org/show_bug.cgi?id=44331
|
|
In gobject-introspection we trust.
https://bugs.freedesktop.org/show_bug.cgi?id=44056
|
|
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=xmpp-console>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The traffic monitor window will need to show nicely-formatted stanzas,
and it will also need a grid with the same spacing.
|