1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
|
/* Template: gsignal */
/*
* No error
*/
{
GObject *some_object = g_malloc (5); // only checking the type
g_signal_connect (some_object, "notify", (GCallback) object_notify_cb,
NULL);
}
/*
* No error
*/
{
GObject *some_object = g_malloc (5); // only checking the type
// Detailed signal
// FIXME: Check the detail is a valid property name too?
g_signal_connect (some_object, "notify::something",
(GCallback) object_notify_cb, NULL);
}
/*
* No error
*/
{
GObject *some_object = g_malloc (5); // only checking the type
g_signal_connect (some_object, "notify",
(GCallback) object_notify_proto_cb,
NULL);
}
/*
* Could not check type of handler for signal ‘GObject::notify’. Callback function declaration does not contain parameter types.
* (GCallback) object_notify_no_proto_cb,
* ^
* note: expanded from macro 'g_signal_connect'
* g_signal_connect_data ((instance), (detailed_signal), (c_handler), (data), NULL, (GConnectFlags) 0)
* ^
*/
{
GObject *some_object = g_malloc (5); // only checking the type
g_signal_connect (some_object, "notify",
(GCallback) object_notify_no_proto_cb,
NULL);
}
/*
* Incorrect return type from signal handler for signal ‘GObject::notify’. Expected ‘void’ but saw ‘gboolean’.
* (GCallback) object_notify_invalid_return_cb, NULL);
* ^
* note: expanded from macro 'g_signal_connect'
* g_signal_connect_data ((instance), (detailed_signal), (c_handler), (data), NULL, (GConnectFlags) 0)
* ^
*/
{
GObject *some_object = g_malloc (5); // only checking the type
g_signal_connect (some_object, "notify",
(GCallback) object_notify_invalid_return_cb, NULL);
}
/*
* Incorrect type for argument ‘self’ in signal handler for signal ‘GObject::notify’. Expected ‘GObject *’ but saw ‘GIOStream *’.
* (GCallback) object_notify_invalid_parameter_subclass_cb,
* ^
* note: expanded from macro 'g_signal_connect'
* g_signal_connect_data ((instance), (detailed_signal), (c_handler), (data), NULL, (GConnectFlags) 0)
* ^
*/
{
GObject *some_object = g_malloc (5); // only checking the type
g_signal_connect (some_object, "notify",
(GCallback) object_notify_invalid_parameter_subclass_cb,
NULL);
}
/*
* Incorrect type for argument ‘self’ in signal handler for signal ‘GObject::notify’. Expected ‘GObject *’ but saw ‘const GObject *’.
* (GCallback) object_notify_invalid_parameter_const_cb,
* ^
* note: expanded from macro 'g_signal_connect'
* g_signal_connect_data ((instance), (detailed_signal), (c_handler), (data), NULL, (GConnectFlags) 0)
* ^
*/
{
GObject *some_object = g_malloc (5); // only checking the type
g_signal_connect (some_object, "notify",
(GCallback) object_notify_invalid_parameter_const_cb,
NULL);
}
/*
* Incorrect type for argument ‘pspec’ in signal handler for signal ‘GObject::notify’. Expected ‘GParamSpec *’ but saw ‘void *’.
* (GCallback) object_notify_invalid_parameter_middle_cb,
* ^
* note: expanded from macro 'g_signal_connect'
* g_signal_connect_data ((instance), (detailed_signal), (c_handler), (data), NULL, (GConnectFlags) 0)
* ^
*/
{
GObject *some_object = g_malloc (5); // only checking the type
g_signal_connect (some_object, "notify",
(GCallback) object_notify_invalid_parameter_middle_cb,
NULL);
}
/*
* Incorrect type for argument ‘user_data’ in signal handler for signal ‘GObject::notify’. Expected ‘void *’ but saw ‘guint’.
* (GCallback) object_notify_invalid_parameter_user_data_cb,
* ^
* note: expanded from macro 'g_signal_connect'
* g_signal_connect_data ((instance), (detailed_signal), (c_handler), (data), NULL, (GConnectFlags) 0)
* ^
*/
{
GObject *some_object = g_malloc (5); // only checking the type
g_signal_connect (some_object, "notify",
(GCallback) object_notify_invalid_parameter_user_data_cb,
NULL);
}
/*
* No error
*/
{
// Non-void* pointer types for user_data are allowed.
GObject *some_object = g_malloc (5); // only checking the type
g_signal_connect (some_object, "notify",
(GCallback) object_notify_invalid_parameter_user_data_ptr_cb,
NULL);
}
/*
* No error
*/
{
// As long as object_notify_missing_parameter_cb is using a safe calling
// convention, this is actually fine.
GObject *some_object = g_malloc (5); // only checking the type
g_signal_connect (some_object, "notify",
(GCallback) object_notify_missing_parameter_cb, NULL);
}
/*
* Incorrect number of arguments in signal handler for signal ‘GObject::notify’. Expected 3 but saw 4.
* (GCallback) object_notify_extra_parameter_cb, NULL);
* ^
* note: expanded from macro 'g_signal_connect'
* g_signal_connect_data ((instance), (detailed_signal), (c_handler), (data), NULL, (GConnectFlags) 0)
* ^
*/
{
GObject *some_object = g_malloc (5); // only checking the type
g_signal_connect (some_object, "notify",
(GCallback) object_notify_extra_parameter_cb, NULL);
}
/*
* No signal named ‘invalid-signal’ in GObject class ‘GObject’. To improve static analysis, add a typecast to the GObject parameter of g_signal_connect_data() to the specific class defining the signal. Ensure a GIR file defining that class is loaded.
* g_signal_connect (some_object, "invalid-signal",
* ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
* note: expanded from macro 'g_signal_connect'
* g_signal_connect_data ((instance), (detailed_signal), (c_handler), (data), NULL, (GConnectFlags) 0)
* ^ ~~~~~~~~~~ ~~~~~~~~~~~~~~~~~
*/
{
GObject *some_object = g_malloc (5); // only checking the type
g_signal_connect (some_object, "invalid-signal",
(GCallback) object_notify_cb, NULL);
}
/*
* Incorrect type for argument ‘key’ in signal handler for signal ‘GSettings::changed’. Expected ‘const char *’ but saw ‘gchar *’.
* (GCallback) settings_changed_cb, NULL);
* ^
* note: expanded from macro 'g_signal_connect'
* g_signal_connect_data ((instance), (detailed_signal), (c_handler), (data), NULL, (GConnectFlags) 0)
* ^
*/
{
// Signal handler doesn't mark the key as 'const'.
GSettings *settings = g_malloc (5); // only checking the type
g_signal_connect (settings, "changed",
(GCallback) settings_changed_cb, NULL);
}
/*
* No error
*/
{
GSettings *settings = g_malloc (5); // only checking the type
g_signal_connect (settings, "changed",
(GCallback) settings_changed_const_cb, NULL);
}
/*
* No error
*/
{
GSettings *settings = g_malloc (5); // only checking the type
g_signal_connect_swapped (settings, "changed",
(GCallback) settings_changed_swapped_cb,
NULL);
}
/*
* No error
*/
{
GSettings *settings = g_malloc (5); // only checking the type
gint some_thing[] = { 0, 1, 2 }; // subtype of gpointer, so valid
g_signal_connect_swapped (settings, "changed",
(GCallback) settings_changed_swapped_cb,
some_thing);
}
/*
* No error
*/
{
GSettings *settings = g_malloc (5); // only checking the type
gint some_thing[] = { 0, 1, 2 }; // subtype of gpointer, so valid
g_signal_connect_swapped (settings, "changed",
(GCallback) settings_changed_swapped_cb,
some_thing);
}
/*
* No error
*/
{
GSettings *settings = g_malloc (5); // only checking the type
gint some_thing[] = { 0, 1, 2 }; // not a GInputStream; FIXME: might be marked as invalid in future
g_signal_connect_swapped (settings, "changed",
(GCallback) settings_changed_swapped_stream_cb,
some_thing);
}
/*
* No error
*/
{
GSettings *settings = g_malloc (5); // only checking the type
GFilterInputStream *stream = g_malloc (5); // GInputStream subtype; valid
g_signal_connect_swapped (settings, "changed",
(GCallback) settings_changed_swapped_stream_cb,
stream);
}
/*
* No error
*/
{
GSettings *settings = g_malloc (5); // only checking the type
GObject *stream = g_malloc (5); // GInputStream supertype; FIXME: might be marked as invalid in future
g_signal_connect_swapped (settings, "changed",
(GCallback) settings_changed_swapped_stream_cb,
stream);
}
/*
* No error
*/
{
GSettings *settings = g_malloc (5); // only checking the type
gint some_thing[] = { 0, 1, 2 }; // subtype of gpointer, so valid
g_signal_connect_data (settings, "changed",
(GCallback) settings_changed_swapped_cb,
some_thing, NULL, G_CONNECT_SWAPPED);
}
/*
* No error
*/
{
GSettings *settings = g_malloc (5); // only checking the type
gint some_thing[] = { 0, 1, 2 }; // subtype of gpointer, so valid
g_signal_connect_data (settings, "changed",
(GCallback) settings_changed_swapped_cb,
some_thing, NULL,
G_CONNECT_SWAPPED | G_CONNECT_AFTER);
}
/*
* No error
*/
{
GSettings *settings = g_malloc (5); // only checking the type
GApplication *app = g_malloc (5); // only checking the type
g_signal_connect_swapped (app, "activate",
G_CALLBACK (application_activate_swapped_cb),
settings);
}
/*
* Incorrect number of arguments in signal handler for signal ‘GApplication::activate’. Expected 2 but saw 4.
* G_CALLBACK (application_activate_swapped_excess_arguments_cb),
* ^
* note: expanded from macro 'G_CALLBACK'
* #define G_CALLBACK(f) ((GCallback) (f))
* ^
* note: expanded from macro 'g_signal_connect_swapped'
* g_signal_connect_data ((instance), (detailed_signal), (c_handler), (data), NULL, G_CONNECT_SWAPPED)
* ^
*/
{
GSettings *settings = g_malloc (5); // only checking the type
GApplication *app = g_malloc (5); // only checking the type
g_signal_connect_swapped (app, "activate",
G_CALLBACK (application_activate_swapped_excess_arguments_cb),
settings);
}
/*
* No error
*/
{
// A more typical use of G_CONNECT_SWAPPED, where we use an existing
// function and swap the arguments to avoid writing a wrapper function.
GApplication *app = g_malloc (5); // only checking the type
GObject *some_object = g_malloc (5); // only checking the type
g_signal_connect_swapped (app, "activate",
G_CALLBACK (g_object_run_dispose), some_object);
}
/*
* No error
*/
{
// Connecting to a signal defined on an interface.
GDBusObject *obj = g_malloc (5); // only checking the type
g_signal_connect (obj, "interface-added",
(GCallback) dbus_object_interface_added_cb, NULL);
}
/*
* No error
*/
{
// Connecting to a signal defined on an interface implemented by the
// object.
GDBusObjectProxy *proxy = g_malloc (5); // only checking the type
g_signal_connect (proxy, "interface-added",
(GCallback) dbus_object_interface_added_cb, NULL);
}
|
