gvariant: Add a unit test for abusing g_variant_lookup()

This is the first real bug found in the wild by Tartan, in tp-glib.

1 files changed, 21 insertions, 0 deletions

diff --git a/tests/gvariant-lookup.c b/tests/gvariant-lookup.c
index 22f53ff..4f07e81 100644
--- a/tests/gvariant-lookup.c
+++ b/tests/gvariant-lookup.c
@@ -52,3 +52,24 @@
 	guint not_a_string;
 	g_variant_lookup (existing_variant, "key", "s", &not_a_string);
 }
+
+/*
+ * Unexpected GVariant variadic argument of type 'char *'. Either it should be removed, or a GVariant format string should be added to the format argument to use it. There is no known GVariant representation of the argument’s type, so the argument must be serialized to a GVariant-representable type first.
+ *                           "server", "&s", &server_param);
+ *                           ^
+ * Unexpected GVariant variadic argument of type 'char *'. Either it should be removed, or a GVariant format string should be added to the format argument to use it. There is no known GVariant representation of the argument’s type, so the argument must be serialized to a GVariant-representable type first.
+ *                           "server", "&s", &server_param);
+ *                                     ^
+ * Unexpected GVariant variadic argument of type 'const gchar **' (aka 'const char **'). Either it should be removed, or a GVariant format string should be added to the format argument to use it. There is no known GVariant representation of the argument’s type, so the argument must be serialized to a GVariant-representable type first.
+ *                           "server", "&s", &server_param);
+ *                                           ^
+ */
+{
+	/* Incorrect usage of g_variant_lookup() found in the wild in tp-glib.
+	 * This is the first real bug Tartan found!
+	 * (g_variant_lookup() can only look up one key, not multiple.) */
+	const gchar *account_param, *server_param;
+	g_variant_lookup (existing_variant,
+	                  "account", "&s", &account_param,
+	                  "server", "&s", &server_param);
+}