summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Hanselmann <public@hansmi.ch>2021-05-31 17:54:07 +0200
committerVictor Toso <me@victortoso.com>2021-06-01 21:26:55 +0000
commitd6be5c6906f820fd3c9625408abd397cf7d90421 (patch)
treeb24f41399d343c4443471857fe477c9400c6cebb
parentc243c7244c06cb31d77b1c373726d9798a0c39f9 (diff)
fuzzing: Always use ConsumeData function
FuzzedDataProvider::ConsumeData was added to Clang in Februar 2020. Since the release of Fedora 34 with Clang 12 in April 2021 it's available in a stable Fedora release. By using ConsumeData the number of allocations and data copies is reduced. Signed-off-by: Michael Hanselmann <public@hansmi.ch>
-rw-r--r--fuzzing/usbredirparserfuzz.cc10
1 files changed, 1 insertions, 9 deletions
diff --git a/fuzzing/usbredirparserfuzz.cc b/fuzzing/usbredirparserfuzz.cc
index d163f8d..33e5fb2 100644
--- a/fuzzing/usbredirparserfuzz.cc
+++ b/fuzzing/usbredirparserfuzz.cc
@@ -62,15 +62,7 @@ int parser_read(void *priv, uint8_t *data, int count)
{
log("%s: %d bytes\n", __func__, count);
- // TODO: Switch to FuzzedDataProvider::ConsumeData once Clang 11 and newer
- // can be required
- const std::vector<uint8_t> buf{fdp->ConsumeBytes<uint8_t>(count)};
-
- count = std::min<size_t>(count, buf.size());
-
- memcpy(data, buf.data(), count);
-
- return count;
+ return fdp->ConsumeData(data, count);
}
int parser_write(void *priv, uint8_t *data, int count)