diff options
| author | Michael Hanselmann <public@hansmi.ch> | 2021-07-08 22:46:07 +0200 |
|---|---|---|
| committer | Michael Hanselmann <public@hansmi.ch> | 2021-07-08 23:18:11 +0200 |
| commit | 171c4e1f5a43cf6cfbfa8ace8fdb62ad98f9190d (patch) | |
| tree | f680bd5ae772b3db8fafb8fe9e704889b1bfc3a1 | |
| parent | 265e1e706ff3d974241309954d168014b3433f8f (diff) | |
Use enum value for parse errors in usbredirparser_do_read
A bare `return -2` isn't as understandable as a `return
usbredirparser_read_parse_error`. The latter is also the documented return value
for parser errors.
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
| -rw-r--r-- | usbredirparser/usbredirparser.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/usbredirparser/usbredirparser.c b/usbredirparser/usbredirparser.c index 6640aa1..774e2b7 100644 --- a/usbredirparser/usbredirparser.c +++ b/usbredirparser/usbredirparser.c @@ -1013,21 +1013,21 @@ int usbredirparser_do_read(struct usbredirparser *parser_pub) parser->header.type); parser->to_skip = parser->header.length; parser->header_read = 0; - return -2; + return usbredirparser_read_parse_error; } /* This should never happen */ if (type_header_len > sizeof(parser->type_header)) { ERROR("error type specific header buffer too small, please report!!"); parser->to_skip = parser->header.length; parser->header_read = 0; - return -2; + return usbredirparser_read_parse_error; } if (parser->header.length > MAX_PACKET_SIZE) { ERROR("packet length of %d larger than permitted %d bytes", parser->header.length, MAX_PACKET_SIZE); parser->to_skip = parser->header.length; parser->header_read = 0; - return -2; + return usbredirparser_read_parse_error; } if ((int)parser->header.length < type_header_len || ((int)parser->header.length > type_header_len && @@ -1036,7 +1036,7 @@ int usbredirparser_do_read(struct usbredirparser *parser_pub) parser->header.type, parser->header.length); parser->to_skip = parser->header.length; parser->header_read = 0; - return -2; + return usbredirparser_read_parse_error; } data_len = parser->header.length - type_header_len; if (data_len) { @@ -1045,7 +1045,7 @@ int usbredirparser_do_read(struct usbredirparser *parser_pub) ERROR("Out of memory allocating data buffer"); parser->to_skip = parser->header.length; parser->header_read = 0; - return -2; + return usbredirparser_read_parse_error; } } parser->type_header_len = type_header_len; @@ -1074,7 +1074,7 @@ int usbredirparser_do_read(struct usbredirparser *parser_pub) parser->data_read = 0; parser->data = NULL; if (!r) - return -2; + return usbredirparser_read_parse_error; /* header len may change if this was an hello packet */ header_len = usbredirparser_get_header_len(parser_pub); } |