diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2013-04-19 17:32:09 +0200 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2013-04-22 08:52:21 -0500 |
| commit | 2b316774f60291f57ca9ecb6a9f0712c532cae34 (patch) | |
| tree | fdf4cd08dc4b74c11778d4f4d7fcf141775ff2f1 /qemu-options.hx | |
| parent | cdbf6e165988ab9d7c01da03b9e27bb8ac0c76aa (diff) | |
qemu-char: do not operate on sources from finalize callbacks
Due to a glib bug, the finalize callback is called with the GMainContext
lock held. Thus, any operation on the context from the callback will
cause recursive locking and a deadlock. This happens, for example,
when a client disconnects from a socket chardev.
The fix for this is somewhat ugly, because we need to forego polymorphism
and implement our own function to destroy IOWatchPoll sources. The
right thing to do here would be child sources, but we support older
glib versions that do not have them. Not coincidentially, glib developers
found and fixed the deadlock as part of implementing child sources.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Tested-by: Sander Eikelenboom <linux@eikelenboom.it>
Message-id: 1366385529-10329-5-git-send-email-pbonzini@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'qemu-options.hx')
0 files changed, 0 insertions, 0 deletions