summaryrefslogtreecommitdiff
path: root/hw/rtl8139.c
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2010-06-17 14:17:59 +0300
committerMichael S. Tsirkin <mst@redhat.com>2010-07-11 23:15:22 +0300
commitfdac1d99c4f6078cb3b08f9d21db5f89368bad4b (patch)
treefba1db49a84945a8a79e655f10ab333ec7dc85d0 /hw/rtl8139.c
parentf2b07c92a457be0cdd2ec5d848cded2505b9c350 (diff)
rtl8139: address TODOs
Make rtl8139 spec compliant, fixing reset values for command register. Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/rtl8139.c')
-rw-r--r--hw/rtl8139.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/hw/rtl8139.c b/hw/rtl8139.c
index 441f0a9146..d92981dc0d 100644
--- a/hw/rtl8139.c
+++ b/hw/rtl8139.c
@@ -3357,11 +3357,8 @@ static int pci_rtl8139_init(PCIDevice *dev)
pci_conf = s->dev.config;
pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_REALTEK);
pci_config_set_device_id(pci_conf, PCI_DEVICE_ID_REALTEK_8139);
- /* TODO: value should be 0 at RST#. */
- pci_conf[PCI_COMMAND] = PCI_COMMAND_IO | PCI_COMMAND_MASTER;
pci_conf[PCI_REVISION_ID] = RTL8139_PCI_REVID; /* >=0x20 is for 8139C+ */
pci_config_set_class(pci_conf, PCI_CLASS_NETWORK_ETHERNET);
- /* TODO: value should be 0 at RST# */
pci_conf[PCI_INTERRUPT_PIN] = 1; /* interrupt pin 0 */
/* TODO: start of capability list, but no capability
* list bit in status register, and offset 0xdc seems unused. */