diff options
author | Kevin Wolf <kwolf@redhat.com> | 2013-06-05 14:19:26 +0200 |
---|---|---|
committer | Stefan Hajnoczi <stefanha@redhat.com> | 2013-06-06 11:27:03 +0200 |
commit | a23818f4ff3d7981f49453b739f589e4205930b5 (patch) | |
tree | 3453fa37fece548b66089f4ac2d96f8bf7752b85 | |
parent | 293c51a6ee369228633a8428ab689f14c045ff98 (diff) |
qemu-io: Remove unused args_command
The original intention seems to be something with handling multiple
images at once, but this has never been implemented and the only
function ever registered is implemented to make everything behave like a
"global" command. Just do that unconditionally now.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
-rw-r--r-- | cmd.c | 28 | ||||
-rw-r--r-- | cmd.h | 2 | ||||
-rw-r--r-- | qemu-io.c | 10 |
3 files changed, 2 insertions, 38 deletions
@@ -34,7 +34,6 @@ cmdinfo_t *cmdtab; int ncmds; -static argsfunc_t args_func; static checkfunc_t check_func; static int ncmdline; static char **cmdline; @@ -127,22 +126,6 @@ void add_user_command(char *optarg) cmdline[ncmdline-1] = optarg; } -static int -args_command( - int index) -{ - if (args_func) - return args_func(index); - return 0; -} - -void -add_args_command( - argsfunc_t af) -{ - args_func = af; -} - static void prep_fetchline(void *opaque) { int *fetchable = opaque; @@ -155,7 +138,7 @@ static char *get_prompt(void); void command_loop(void) { - int c, i, j = 0, done = 0, fetchable = 0, prompted = 0; + int c, i, done = 0, fetchable = 0, prompted = 0; char *input; char **v; const cmdinfo_t *ct; @@ -171,14 +154,7 @@ void command_loop(void) if (c) { ct = find_command(v[0]); if (ct) { - if (ct->flags & CMD_FLAG_GLOBAL) { - done = command(ct, c, v); - } else { - j = 0; - while (!done && (j = args_command(j))) { - done = command(ct, c, v); - } - } + done = command(ct, c, v); } else { fprintf(stderr, _("command \"%s\" not found\n"), v[0]); } @@ -41,12 +41,10 @@ extern int ncmds; void help_init(void); void quit_init(void); -typedef int (*argsfunc_t)(int index); typedef int (*checkfunc_t)(const cmdinfo_t *ci); void add_command(const cmdinfo_t *ci); void add_user_command(char *optarg); -void add_args_command(argsfunc_t af); void add_check_command(checkfunc_t cf); const cmdinfo_t *find_command(const char *cmd); @@ -1888,15 +1888,6 @@ static int open_f(int argc, char **argv) return openfile(argv[optind], flags, growable); } -static int init_args_command(int index) -{ - /* only one device allowed so far */ - if (index >= 1) { - return 0; - } - return ++index; -} - static int init_check_command(const cmdinfo_t *ct) { if (ct->flags & CMD_FLAG_GLOBAL) { @@ -2043,7 +2034,6 @@ int main(int argc, char **argv) add_command(&wait_break_cmd); add_command(&abort_cmd); - add_args_command(init_args_command); add_check_command(init_check_command); /* open the device */ |