cac: Avoid pointers from static structure to the function-local variables after return

clang error:

libcacard-2.5.2/src/cac.c:2021:1: warning: Address of stack memory associated with local variable 'number_objects' is still referred to by the global variable 'properties' upon returning to the caller.  This will be a dangling reference

Signed-off-by: Jakub Jelen <jjelen@redhat.com>

1 files changed, 5 insertions, 0 deletions

diff --git a/src/cac.c b/src/cac.c
index 2c96c4a..687a828 100644
--- a/src/cac.c
+++ b/src/cac.c
@@ -1992,6 +1992,11 @@ cac_new_empty_applet_private(unsigned char objects[][2], unsigned int objects_le
     applet_private->properties_len = properties_len;
     applet_private->long_properties_len = properties_len; /*TODO*/
     applet_private->properties = simpletlv_clone(properties, properties_len);
+
+    /* Avoid dangling pointers in the static structure */
+    properties[0].value.value = NULL;
+    properties[1].value.value = NULL;
+
     if (applet_private->properties == NULL)
         goto failure;