diff options
| author | Rex Dieter <rdieter@math.unl.edu> | 2016-06-01 10:09:45 +0530 |
|---|---|---|
| committer | Arun Raghavan <arun@arunraghavan.net> | 2016-06-01 10:09:45 +0530 |
| commit | d58164e4d87854233564b59e76259b72e21507f6 (patch) | |
| tree | f08b7af34b7d87c2fc91a389fe5d63cf035f98ef | |
| parent | 9a0e28cab06f43d10cd00b69fc14dee78a73c2d0 (diff) | |
build: enforce linking with --no-undefined, add explicit -lpthread
In investigating x86/sse2 issues in recent webrtc-audio-processing-0.2
release, I found that it was possible for libwebrtc_audio_processing to
contain undefined symbols.
Attached is a patch that addresses this:
* adds -Wl,--no-undefined to libwebrtc_audio_processing_la_LDFLAGS
* adds explicit -lpthread linkage (else, there are undefined references
to pthread-related symbols)
Signed-off-by: Arun Raghavan <arun@arunraghavan.net>
| -rw-r--r-- | webrtc/modules/audio_processing/Makefile.am | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/webrtc/modules/audio_processing/Makefile.am b/webrtc/modules/audio_processing/Makefile.am index b685fb9..6a5c508 100644 --- a/webrtc/modules/audio_processing/Makefile.am +++ b/webrtc/modules/audio_processing/Makefile.am @@ -166,8 +166,11 @@ libwebrtc_audio_processing_la_LIBADD = $(top_builddir)/webrtc/libwebrtc.la \ $(top_builddir)/webrtc/base/libbase.la \ $(top_builddir)/webrtc/system_wrappers/libsystem_wrappers.la \ $(top_builddir)/webrtc/common_audio/libcommon_audio.la \ - $(top_builddir)/webrtc/modules/audio_coding/libaudio_coding.la -libwebrtc_audio_processing_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(LIBWEBRTC_AUDIO_PROCESSING_VERSION_INFO) + $(top_builddir)/webrtc/modules/audio_coding/libaudio_coding.la \ + -lpthread +libwebrtc_audio_processing_la_LDFLAGS = $(AM_LDFLAGS) \ + -Wl,--no-undefined \ + -version-info $(LIBWEBRTC_AUDIO_PROCESSING_VERSION_INFO) # FIXME: The MIPS optimisations need to be hooked up once we have the # autotools conditionals in place |