Age | Commit message (Collapse) | Author | Files | Lines |
|
With the option to hide some profiles, we need to track the list store
index separately from the profile list iterator, so that the active
selection in the dropdown is correct. We also need to allow an invalid
selection, as an unavailable profile might be selected.
|
|
|
|
|
|
|
|
Fixes https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/issues/153
|
|
Build system and documentation updates.
|
|
Center looks strange, so we use fill and a little more margin to make
things look a little better.
Credit to psykose <alice@ayaya.dev> for first identifying the problem
and proposing a fix.
|
|
The reference is owned by the VBox, so we remove it there and it gets
cleaned up, like other widgets.
Fixes: https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/issues/162
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/merge_requests/98>
|
|
With the addition of the appstream file, the app is showing up in Flathub
and software apps (like GNOME Software) as "Volume Control", but on the
desktop (using the Desktop file), it's showing up differently as
"PulseAudio Volume Control", which is confusing.
Like commit be02260941 mentions, there are some guidelines for naming apps
which prefer the shorter "Volume Control" more than "PulseAudio
Volume Control". It also helps for example GNOME users who get an
ellipsized name in GNOME Software and the GNOME desktop.
To make sure people still get a hit on "PulseAudio" when searching for
the app, let's add that specifically to the tags. That should prevent
search from breaking in a lot of cases.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/merge_requests/97>
|
|
The value needs to be "yes" rather than "1" for the pot/po files to be
updated correctly.
Shoutout to Thomas Lange for reporting the issue and deducing the fix.
Fixes: https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/issues/156
|
|
|
|
There are a few things to keep in mind:
* We'll have a lot of non-functional application icons, because app
icons don't always exist in the icon theme, so use the generic
application icon
* There is no audio-card icon in the theme any more, so add fallback
to the symbolic version
|
|
The .desktop file name has changed.
|
|
and some cleanup
|
|
Remove a lot of unrequired ids, and fix meson dependency name
|
|
libcanberra is an old abandoned project whose last release
was well over a decade ago, despite getting some few fixes
on its master branch since then, which are unreleased.
My problem with libcanberra is that it can't be built on
pure wayland systems (no X11 headers) which are becoming
more common nowadays.
It is the only thing keeping pavucontrol tied to X11, all
other dependencies (eg gtk+) build fine on pure wayland.
Since canberra is not a core part of the project, let's
make it optional so pavucontrol can build & work on
pure wayland systems.
Ideally in the future libcanberra can be replaced with
something else, however I don't have the bandwidth to
take this on for now, so I'm just making it optional.
Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>
|
|
We should really just get a clang-format config that's close enough and
set that up instead.
|
|
|
|
|
|
|
|
|
|
|
|
We've had the meson build for a bit, and it's faster and cleaner to
maintain.
|
|
These are taken from README.html.in, without the information about new
dependencies (IMHO not useful to end-users) or “Some bug fixes.” (IMHO
not specific enough to be useful).
|
|
This file is taken from the Flathub package, as of
https://github.com/flathub/org.pulseaudio.pavucontrol/pull/31 where I
have adjusted the name & summary to conform to Flathub's rules. In
particular:
- The name must be no more than 20 characters, so I have used “Volume
Control” to match the window title and GenericName
- The summary must be no more than 35 characters.
I noticed while preparing this patch that the Comment in the .desktop
file (which the appstream specification says is “roughly equivalent” to
the <summary>) is just “Adjust the volume level”. IMO “Adjust the volume
level” contains no more information than the name “Volume Control”.
Fixes https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/issues/127
|
|
Update the sample rate to 144 to keep up with high refresh rate
monitors.
|
|
The "Set as fallback" title is a frequent source of confusion, many
people look at it and do not realize that its actual functional is
"setting as default". Presumably, when this title first appeared it
was presumed that apps should chose a device themselves, and then if
they don't there's a "fallback". But in reality most apps do not chose
any device explicitly, and it's expected behavior to make use of this
"fallback" device. So it is more correct to call a "default" device.
|
|
this fixes #124
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/merge_requests/73>
|
|
To match the autotools build.
|
|
With the underscore, we got:
../src/pavucontrol.desktop.in:12:0: warning: invalid non-blank line
|
|
The only missing feature for parity with autotools is generating a text
README using lynx. I think this might be okay to skip as it seems
unnecessary as a dependency.
|
|
Newer gettext has feature parity, rendering intltool obsolete. Details
at:
https://wiki.gnome.org/MigratingFromIntltoolToGettext
|
|
Also add toggles for TrueHD and DTS-HD formats in the sink widget.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/merge_requests/71>
|
|
Most of sink input peak indicator streams are still connected alive at the time
their widgets are destroyed. Disconnect and unreference each one to stop memory
leak.
When sink input peak indicator stream is recreated, previous stream is only
disconnected but not unreferenced. Unreference it to stop memory leak.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/merge_requests/62>
|
|
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/merge_requests/60>
|
|
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/merge_requests/59>
|
|
Server API versions < 35 do not support PA_COMMAND_SEND_OBJECT_MESSAGE
one of these is current Pipewire pulseaudio server.
Do not quit on error sending message to object, this is already handled as if
send message API is not available.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/merge_requests/57>
|
|
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/merge_requests/54>
|
|
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/merge_requests/53>
|
|
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pavucontrol/-/merge_requests/50>
|
|
The end result is the same, so this isn't strictly needed - originally
this patch fixed a segfault, but that segfault got fixed in a different
way before merging this patch.
|
|
This was accomplished by building with -DGTKMM_DISABLE_DEPRECATED.
|
|
Add a bit more padding for when percentages and decibel levels are weird
so that sliders and labels are a consistent width.
|
|
|
|
|
|
|
|
This allows pavucontrol to be specifically addressed when creating GTK
themes.
|
|
|
|
Fixes this compilation issue:
pavuapplication.cc: In function ‘int main(int, char**)’:
pavuapplication.cc:146:32: error: use of deleted function ‘PavuApplication::PavuApplication(PavuApplication&&)’
auto app = PavuApplication();
^
In file included from pavuapplication.cc:29:0:
pavuapplication.h:27:7: note: ‘PavuApplication::PavuApplication(PavuApplication&&)’ is implicitly deleted because the default definition would be ill-formed:
class PavuApplication : public Gtk::Application {
^
In file included from /usr/include/gtkmm-3.0/gtkmm/window.h:32:0,
from /usr/include/gtkmm-3.0/gtkmm/dialog.h:30,
from /usr/include/gtkmm-3.0/gtkmm/aboutdialog.h:33,
from /usr/include/gtkmm-3.0/gtkmm.h:99,
from pavucontrol.h:29,
from pavuapplication.h:24,
from pavuapplication.cc:29:
/usr/include/gtkmm-3.0/gtkmm/application.h:211:3: error: ‘Gtk::Application::Application(const Gtk::Application&)’ is private
Application(const Application&);
^
In file included from pavuapplication.cc:29:0:
pavuapplication.h:27:7: error: within this context
class PavuApplication : public Gtk::Application {
^
In file included from /usr/include/glibmm-2.4/glibmm/wrap.h:26:0,
from /usr/include/glibmm-2.4/glibmm/containerhandle_shared.h:26,
from /usr/include/glibmm-2.4/glibmm/arrayhandle.h:23,
from /usr/include/glibmm-2.4/glibmm.h:91,
from /usr/include/gtkmm-3.0/gtkmm.h:87,
from pavucontrol.h:29,
from pavuapplication.h:24,
from pavuapplication.cc:29:
/usr/include/glibmm-2.4/glibmm/objectbase.h:238:3: error: ‘Glib::ObjectBase::ObjectBase(const Glib::ObjectBase&)’ is private
ObjectBase(const ObjectBase&);
^
In file included from pavuapplication.cc:29:0:
pavuapplication.h:27:7: error: within this context
class PavuApplication : public Gtk::Application {
^
|
|
Fixes a warning with the 'Valve VR Radio & HMD Mic' device.
|