| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
Acked-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/586>
|
|
Calling piglit_link_check_status without checking return value
Reported-by: Coverity Scan
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/251>
|
|
There is still a huge number of tests to classify but this gives us
a good number of tests to start testing with.
|
|
Analogous to previous commit(s).
With this commit no GL test in piglit (barring glean) relies on this
broken behaviour. Checked with the following:
$ git grep "defined.*\<GL_"
$ git grep "ifdef.*\<GL_"
Only local definitions can be seen with the inverse query
$ git grep "ifndef.*\<GL_"
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
|
|
All that mesa does when releasing the shader compiler is clear its
builtins list. So make sure to use a builtin, and release the compiler
sooner, to trigger a bug in mesa.
This code sequence is hit by some core Android component.
Reported-by: Rob Herring <robh@kernel.org>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Reviewed-by: Timothy Arceri <timothy.arceri@collabora.com>
|
|
This patch was created by:
sed -i -e '/[{]OPENGL_glu_LIBRARY[}]/d' $(grep -lr OPENGL_glu_LIBRARY)
git checkout tests/glean/CMakeLists.gl.txt
git checkout tests/spec/gl-1.4/CMakeLists.gl.txt
git checkout tests/fbo/CMakeLists.gl.txt
So, there are three places out of all of piglit that actually need
this library.
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Thanked-by: Kristian Høgsberg <krh@bitplanet.net>
|
|
Report PIGLIT_FAIL if there's an unexpected error.
Reviewed-by: Brian Paul <brianp@vmware.com>
|
|
The piglit_probe_rect_depth() was invalid because it was using the
piglit window size rather than the FBO size.
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
|
|
There are no longer any source files in tests/util that are specific to
a particular OpenGL API. In other words, all OpenGL utility sources in
tests/util are now "common" and shared by all OpenGL APIs. So remove the
'common' in filename 'piglit-util-gl-common.h'.
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
|
|
Reviewed-by: José Fonseca <jfonseca@vmware.com>
|
|
Tested-by: Dylan Baker <baker.dylan.c@gmail.com>
|
|
Since I was about to clean up some piglit_compile_shader_text calls, I
was looking at all these anyway.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
|
|
Changes:
- SINGLE is removed, because its value was 0
- ALPHA is removed, because it becomes redundant with this change
- RGB asks for an RGB visual
- RGBA asks for an RGBA visual
- if RGB and RGBA are unset, it asks for a visual without RGB(A)
Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Chris Forbes <chrisf@ijw.co.nz>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
v2: fix glut
|
|
Reviewed-by: José Fonseca <jfonseca@vmware.com>
|
|
This patch has 3 interrelated components.
1) Add the following fields to piglit_gl_test_config:
supports_gl_core_version
supports_gl_compat_version
supports_gl_es1
supports_gl_es2
These allow a test to specify what GL flavors under which it can run. For
details, see the documentation for struct piglit_gl_test_config.
2. In tests/util/piglit-framework-gl, implement support for the new
fields.
3. In each GL test source, add one of the new fields to the
PIGLIT_GL_TEST_CONFIG_BEGIN/END block.
For GLES1 tests, add `supports_gl_es1 = true`. For GLES2 tests, add
`supports_gl_es2 = true`. For desktop GL tests, add
`supports_gl_compat_version = 10`. For an explanation of why version 1.0
is used for desktop GL tests, see the documentation for
supports_gl_compat_version. No tests yet require a GL core context.
v2: Replace silly sum of booleans with a logical conjuction. For Anholt.
Reviewed-and-tested-by: Jordan Justen <jordan.l.justen@intel.com>
Tested-by: Paul Berry <stereotype441@gmail.com>
Acked-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
|
|
This patch has two components.
1. In tests/util/piglit-framework-gl.h, replace the definition of
PIGLIT_GL_TEST_MAIN with the macro block PIGLIT_GL_CONFIG_BEGIN/END.
The macro PIGLIT_GL_TEST_MAIN was very restrictive. It was a fixed-arity
macro function that allowed a test to set only set 3 values: window width,
height, and visual. It would have been difficult to shoehorn optional test
attributes into such a fixed-arity macro function. Allowing optional
attributes is an essential feature because a following commit adds
optional fields to struct piglit_gl_test_config.
The macro block PIGLIT_GL_TEST_CONFIG_BEGIN/END is more flexible. Within
it the test is allowed to arbitrarilty modify the piglit_gl_test_config
structure.
2. In each GL test source, replace PIGLIT_GL_TEST_MAIN with
a PIGLIT_GL_TEST_CONFIG_BEGIN/END block.
Reviewed-and-tested-by: Jordan Justen <jordan.l.justen@intel.com>
Tested-by: Paul Berry <stereotype441@gmail.com>
Acked-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
|
|
I'm trying to transition Piglit from using GLUT to using Waffle. That
requires either killing or wrapping all GLUT code.
Define enum piglit_gl_visual in piglit-framework.h, of which each value
matches its corresponding GLUT visual enum.
Do the following substitution in all util and test sources:
GLUT_RGB -> PIGLIT_GL_VISUAL_RGB
GLUT_RGBA -> PIGLIT_GL_VISUAL_RGBA
GLUT_DOUBLE -> PIGLIT_GL_VISUAL_DOUBLE
GLUT_ACCUM -> PIGLIT_GL_VISUAL_ACCUM
GLUT_ALPHA -> PIGLIT_GL_VISUAL_ALPHA
GLUT_DEPTH -> PIGLIT_GL_VISUAL_DEPTH
GLUT_STENCIL -> PIGLIT_GL_VISUAL_STENCIL
v2: Remove GLUT_INDEX, for Ken.
Reviewed-and-tested-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Tested-by: Paul Berry <stereotype441@gmail.com>
Acked-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
|
|
|
|
Generated from the following semantic patch.
@@
expression RET, MSG;
@@
- RET = glGetError();
- if (RET != 0) {
+ if (!piglit_check_gl_error(GL_NO_ERROR))
(
- printf(MSG,RET);
|
- fprintf(stderr,MSG,RET);
)
piglit_report_result(PIGLIT_FAIL);
- }
Signed-off-by: Chris Forbes <chrisf@ijw.co.nz>
Reviewed-by: Brian Paul <brianp@vmware.com>
|
|
Generated from the following semantic patch:
@@
expression VER;
expression MSG;
@@
- if (piglit_get_gl_version() < VER) {
- printf(MSG);
- piglit_report_result(PIGLIT_SKIP);
(
- exit(1);
|
)
- }
+ piglit_require_gl_version(VER);
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Chris Forbes <chrisf@ijw.co.nz>
|
|
V2: Don't break tests/general/read-front
Reviewed-by: Paul Berry <stereotype441@gmail.com>
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
|
|
Build gl utilities to piglitutil_gl library insted of piglitutil.
As a result all executables linking to piglitutil library now link to
piglitutil_gl.
Signed-off-by: Blaž Tomažič <blaz.tomazic@gmail.com>
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
|
|
Move piglit-util.* to piglit-util-gl-common.*
Signed-off-by: Blaž Tomažič <blaz.tomazic@gmail.com>
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
|
|
Each test that did not define main() now does so using
PIGLIT_GL_TEST_MAIN().
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
|
|
Nearly all CMakeLists.gl.txt contained the following:
include_directories(${GLUT_INCLUDE_DIR})
link_libraries(${GLUT_glut_LIBRARY})
This patch relocates them to cmake/target_api/gl/CMakeLists.txt.
Reviewed-by: Pauli Nieminen <pauli.nieminen@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
|
|
Replace
add_executable -> piglit_add_executable
add_library -> piglit_add_library
For now, each wrapper function trivially wraps the function it replaces,
and so this patch changes no behavior.
This commit was created using the command:
sed -i -e "s/add_executable/piglit_add_executable/" -e "s/add_library/piglit_add_library/" $(find src/ tests/ -name "*CMakeLists*")
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
|
|
Several tests were checking for the presence of GL extensions using
GLEW macros. This patch changes the tests to use
piglit_is_extension_supported(), which provides the same functionality
in a way that is not dependent on GLEW.
v2: Follow piglit convention of including "GL_" in the string passed
to piglit_is_extension_supported().
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
|
|
Several tests were checking the GL version using GLEW's GLEW_VERSION_*
macros. This patch changes the tests to use piglit_get_gl_version(),
which provides the same functionality in a way that is not dependent
on GLEW.
Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
|
|
It was impossible to have the source directory read-only.
Also add the include_directories() directive for tests/util
in just one place, under tests/, so that all subdirectories
inherit it. A bunch of CMakeLists.txt files duplicate it,
so delete those redundant include flags:
sed -i -e "/^\t\${piglit_SOURCE_DIR}\/tests\/util/ d" \
`grep piglit_SOURCE_DIR -rl tests/ | grep "CMakeLists\.gl"`
|
|
|
|
There are four ways this test can be run.
- Color/depth blit to an FBO w/o color with draw buffer = NONE
- Color/depth blit to an FBO w/o color with draw buffer != NONE (ES2
FBO completeness rules).
- Color/depth blit from an FBO w/o color with draw buffer = NONE
- Color/depth blit from an FBO w/o color with draw buffer != NONE
(ES2 FBO completeness rules).
In addition, after the blit the values in the depth buffer are probed
to make sure that part of the blit happened.
Reviewed-by: Eric Anholt <eric@anholt.net>
|
|
The relaxed completeness rules in ARB_ES2_compatibility allow clearing
the color buffer of an FBO that lacks a color attachment and has the
draw buffer set to non-GL_NONE.
Reproduces Mesa bugzilla #37739.
Reviewed-by: Eric Anholt <eric@anholt.net>
|
|
It's only used by glean, so no need to force linking against it everywhere.
|
|
|
|
|
|
glext.h is not bundled on MSVC, so its path needs to be included
separately.
It might be also useful on other platforms to override the system's
glext.h with a more recent one.
|
|
In preparation for adding GLES2 targets to Piglit, it is necessary to
compartmentalize the GL targets and the GLES2 targets (of which none yet
exist) in API-specific CMake files. Since all CMake targets currently use
the OpenGL API, achieving compartmentalization is as simple as renaming
each CMakeLists.txt.
Note: This belongs to a series that adds GLES2 support to Piglit.
Signed-off-by: Chad Versace <chad.versace@intel.com>
|
|
This fixes out-of-source builds, and does not harm in-source builds.
CMake is intelligent enough to add the appropriate link directories
itself.
Signed-off-by: Chad Versace <chad.versace@intel.com>
|
|
Discussed on IRC.
Finally we have headers for OpenGL 4.1 and all the extensions released
to this day.
|
|
Use #version 100 shaders.
Use generic attribute 0 instead of gl_Vertex.
Don't use gl_ModelViewProjectionMatrix.
Use GL_TRIANGLE_STRIP instead of GL_QUADS.
Make sure all the shaders need are actually included. Previously
glsl-uniform-color.frag was not in the GIT repo.
|
|
In case glew.h isn't up to date.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
