diff options
| author | Anthony Pesch <apesch@nvidia.com> | 2018-04-11 09:45:08 -0700 |
|---|---|---|
| committer | Juan A. Suarez Romero <jasuarez@igalia.com> | 2018-04-11 19:21:33 +0200 |
| commit | 9b0504712dd816007bddf2502f23c07d698ecb17 (patch) | |
| tree | 4773a51f34c337e22fdae945d5ee0280d7d73101 | |
| parent | f2a0ebb4bab771983eb2f5afefa60adb78767382 (diff) | |
arb_get_texture_sub_image: fix depth parameter when performing zero-sized texture queries
Change zero-sized texture queries to pass a valid depth parameter, otherwise
they should error as per the OpenGL 4.6 Core spec:
"An INVALID_VALUE error is generated if the effective target is TEXTURE_1D,
TEXTURE_1D_ARRAY, TEXTURE_2D or TEXTURE_RECTANGLE, and either zoffset is not
zero, or depth is not one."
Reviewed-by: Arthur Huillet <ahuillet@nvidia.com>
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com>
| -rw-r--r-- | tests/spec/arb_get_texture_sub_image/errors.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/spec/arb_get_texture_sub_image/errors.c b/tests/spec/arb_get_texture_sub_image/errors.c index 57875fa6a..1e7b17115 100644 --- a/tests/spec/arb_get_texture_sub_image/errors.c +++ b/tests/spec/arb_get_texture_sub_image/errors.c @@ -293,7 +293,7 @@ test_zero_size_image(void) /* getting 0x0 image from 8x8 source should work */ glGetTextureSubImage(tex, 0, 0, 0, 0, - 0, 0, 0, + 0, 0, 1, GL_RGBA, GL_UNSIGNED_BYTE, sizeof(image), image); if (!piglit_check_gl_error(GL_NO_ERROR)) @@ -306,7 +306,7 @@ test_zero_size_image(void) /* getting 0x0 image from 0x0 source should work */ glGetTextureSubImage(tex, 0, 0, 0, 0, - 0, 0, 0, + 0, 0, 1, GL_RGBA, GL_UNSIGNED_BYTE, sizeof(image), image); if (!piglit_check_gl_error(GL_NO_ERROR)) @@ -315,7 +315,7 @@ test_zero_size_image(void) /* getting 0x0 image at an offset from 0x0 source should error */ glGetTextureSubImage(tex, 0, 1, 2, 0, /* offset */ - 0, 0, 0, + 0, 0, 1, GL_RGBA, GL_UNSIGNED_BYTE, sizeof(image), image); if (!piglit_check_gl_error(GL_INVALID_VALUE)) |