summaryrefslogtreecommitdiff
path: root/tools/Connect.cpp
AgeCommit message (Collapse)AuthorFilesLines
2020-06-02wsd: move LOOLProtocol::tokenize to Util::tokenizeAshod Nakashian1-1/+1
The tokenizer(s) are more generic than the protocol logic, and are used from contexts that don't involve the protocol as such. Change-Id: Ie8c256bf11a91e466bff794021f41603c9596a7f
2020-06-02wsd: single-char string literals -> charAshod Nakashian1-1/+1
More readable and typically more efficient. Change-Id: I9bd5bfc91f4ac255bb8ae0987708fb8b56b398f8 Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95285 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-04-18killpoco: remove WebSocket includes from a couple of places.Michael Meeks1-1/+1
Change-Id: I06740cd978bec8e6a74beb8ed9ef8f4f970a2535 Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92470 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-04-08killpoco: removed Poco::Thread from tools directoryPranam Lashkari1-5/+1
Change-Id: I3fc4a04c62a064eaefd5c31452abc4a7fe100fb4 Reviewed-on: https://gerrit.libreoffice.org/c/online/+/83224 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-03-09Introduce StringVector::equals()Miklos Vajna1-1/+1
Allows comparing tokens with C strings without a heap allocation. Do the same when comparing two tokens from two different StringVectors. And use it at all places where operator ==() has an argument, which is a StringVector::operator []() result. Change-Id: Id36eff96767ab99b235ecbd12fb14446a3efa869 Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90201 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-02-28Rework LOOLProtocol::tokenize() to return a StringVector objectMiklos Vajna1-1/+1
The bulk of this commit just changes std::vector<std::string> to StringVector when we deal with tokens from a websocket message. The less boring part of it is the new StringVector class, which is a wrapper around std::vector<std::string>, and provides the same API, except that operator[] returns a string, not a string&, and this allows returning an empty string in case that prevents reading past the end of the underlying array. This means in case client code forgets to check size() before invoking operator[], we don't crash. (See the ~3 previous commits which fixed such crashes.) Later the ctor could be changed to take a single underlying string to avoid lots of tiny allocations, that's not yet done in this commit. Change-Id: I8a6082143a8ac0b65824f574b32104d7889c184f Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89687 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-13killpoco: removed StringTokenizer from tools directoryPranam Lashkari1-3/+1
removed use of Poco::StringTokenizer from the tools directory using LOOLProtocol::tokenize and std::vecor<std::string> Change-Id: I0673e658fd35cbdc7425a99f1dcea0b54923f52c Reviewed-on: https://gerrit.libreoffice.org/82568 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-07killpoco: Don't use POCO for app exit values.Jan Holesovsky1-3/+4
Change-Id: I2948ac45a7b4243f7afde08d5245530fdbf9a070 Reviewed-on: https://gerrit.libreoffice.org/82125 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-01-15tools: make members private in ConnectMiklos Vajna1-0/+1
It was not used externally. Change-Id: Ie96af8aa4c72efc17c40f453ce200e520d954365
2018-04-17Initial websocket test tool for remote admin connections.Michael Meeks1-7/+4
Change-Id: I8be2068bf7d77c70720a044556d11f5fc80b2f0c
2017-12-20loplugin:includeformPranav Kant1-5/+5
Change-Id: Ib62a7aa61062f00698aa3e8a144438de5c57e53d
2016-12-31wsd: include cleanupAshod Nakashian1-8/+0
Change-Id: Id481cfbab6be12a095918bdc7318fb3584345307 Reviewed-on: https://gerrit.libreoffice.org/32548 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-12-22loplugin:unnecessaryoverrideNoel Grandin1-4/+0
Change-Id: Ib077de07e832ae30137f465596961731954d8e62 Reviewed-on: https://gerrit.libreoffice.org/32340 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-12-22add a configure option for using clang compiler pluginsNoel Grandin1-1/+1
and apply the nullptr plugin. Lots of hacking in my LO tree required to make this work, will probably end up needing to add an extra parameter to the LO side. Change-Id: I02ae1dcdece9d9ddf05f7757f6696e3a5d7d1f14 Reviewed-on: https://gerrit.libreoffice.org/32339 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-12-21wsd: logging updatesAshod Nakashian1-1/+1
Change-Id: Icbee0349a3cfda5a56f8d681c779484e18b98ab6 Reviewed-on: https://gerrit.libreoffice.org/32287 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-11-25Adapt makefiles, includes etc. to new locations.Michael Meeks1-1/+1
2016-11-25Apply the pre-branch rename script to re-organize the source.Michael Meeks1-0/+262