diff options
| author | Fridrich Štrba <fridrich.strba@bluewin.ch> | 2013-07-22 22:16:15 +0200 |
|---|---|---|
| committer | Fridrich Štrba <fridrich.strba@bluewin.ch> | 2013-07-22 22:16:15 +0200 |
| commit | 7d74f52e9d7212639427f0c69130e6c4a231a461 (patch) | |
| tree | 5d52ee43826def9332805298d2ebdd42f3faaffe | |
| parent | b63cef2b299728328ff33a44ba0cfc20673949af (diff) | |
Cppcheck: (performance) Function parameter 'weights' should be passed by reference
| -rw-r--r-- | src/lib/VSDContentCollector.cpp | 2 | ||||
| -rw-r--r-- | src/lib/VSDContentCollector.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/VSDContentCollector.cpp b/src/lib/VSDContentCollector.cpp index da345bf..6063fe2 100644 --- a/src/lib/VSDContentCollector.cpp +++ b/src/lib/VSDContentCollector.cpp @@ -1521,7 +1521,7 @@ void libvisio::VSDContentCollector::_generatePolylineFromNURBS(unsigned degree, } } -bool libvisio::VSDContentCollector::_isUniform(const std::vector<double> weights) const +bool libvisio::VSDContentCollector::_isUniform(const std::vector<double> &weights) const { if (weights.empty()) return true; diff --git a/src/lib/VSDContentCollector.h b/src/lib/VSDContentCollector.h index b34e9d1..4889770 100644 --- a/src/lib/VSDContentCollector.h +++ b/src/lib/VSDContentCollector.h @@ -221,7 +221,7 @@ private: void _appendField(WPXString &text); // NURBS processing functions - bool _isUniform(const std::vector<double> weights) const; + bool _isUniform(const std::vector<double> &weights) const; void _generatePolylineFromNURBS(unsigned degree, const std::vector<std::pair<double, double> > &controlPoints, const std::vector<double> &knotVector, const std::vector<double> &weights); void _generateBezierSegmentsFromNURBS(unsigned degree, const std::vector<std::pair<double, double> > &controlPoints, |