summaryrefslogtreecommitdiff
path: root/chart2
AgeCommit message (Collapse)AuthorFilesLines
2020-03-09tdf#131060 tdf#117088 chart view: fix missing or truncated axis labelsBalazs Varga1-11/+28
if we have enough space under the horizontal X axis. Note: allow truncation of vertical X axis labels only if they are text labels and the position is NEAR_AXIS or OUTSIDE_START. Regressions from commit 35d062f7879d5414334643cb90bff411726b2168 (tdf#116163: Limit label height in chart if needed) and commit 26caf1bc59c81704f11225e3e431e412deb8c475 (tdf#114179: Custom size and position of the chart wall) Change-Id: Idf86bc2b5482bb50a266cda57cc502621c2e08ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89829 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-09tdf#131143 OOXML chart: fix missing data points of scatter chartBalazs Varga2-0/+13
If "values-x" property is empty, export X-Y (scatter) chart category labels in c:xVal/c:strRef/c:strCache/c:pt/c:v to avoid missing data points at next import. Change-Id: Ib5ed99bd1186bd1cfa3e2559aff1c8d214547017 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90011 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-06basegfx: B2DTuple replace operator[] with "get" and Axis2D enumTomaž Vajngerl1-13/+13
opertaor[] was used for index access of of x and y variables where 0 is x and 1 is y - similar like access to an array with 2 elements. This comes in handy when you write generic code where the algorithm is the same for x and y, but using index access operator doesn't look clean and is potentially dangerous. We know we only have 2 options (o and 1), but an index access allows for more. A solution to this is to have a normal "get" method, with an enum as parameter (Axis2D), which can only have values X or Y. Change-Id: I3f98d0149214808a336f25599350a78436236827 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90133 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-06loplugin:unusedmethodsNoel Grandin2-21/+0
Change-Id: I698981490eb1391930cdd06821a80a5f770e000e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-06tdf#123268 fix lost chart if all legend entries are hiddenTünde Tóth1-0/+2
See also commit 19b2ed4dee1ec33ad55473d43bfcd0bfa194cbee (related tdf#51671, add UI options for new "hide legend entry" feature) Change-Id: If20ab167d867d2845fa414ba0bbc490bed09f61c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89123 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-05tdf#75330 chart: implement ODF import/export of legend overlay featureTünde Tóth2-0/+16
Follow-up of commit 9fab1ba8ddc59924c633aa17c65f7330a4762726 (tdf#75330 add a new overlay/no-overlay feature for the legend). Change-Id: I7781fd8b926d4add56f3db0d56dceab8e27e5f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89836 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-05tdf#75330 add a new overlay/no-overlay feature for the legendTünde Tóth12-73/+241
Implement "Show the legend without overlapping the chart" option for chart legend. Change-Id: Ifbba4c81136e13995d276434dc17a97b0675428c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89810 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-03tdf#130777 UI: add Hide legend entry option for pie chartTünde Tóth14-7/+266
Follow-up of the following commits related to the new UNO property DeletedLegendEntries for pie charts: commit a96ec04a07c35338f5f9a0cb361b9322e5ca9cec (tdf#130225 implement ODF export of deleted legend entries of pie charts) commit 86be3422cd55fa9e44104f1628648061bb6a3495 (tdf#129857 Chart OOXML export: fix deleted legend entries) commit 6e847aa817999ab18acd534f9e6a86685bb268fc (tdf#129859 XLSX import: don't show deleted legend entries) Change-Id: I8b13823da745dfbfbf20f1d30f742c4baf803fc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89456 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-03Revert "Make Chart Creation Wizard async"Stephan Bergmann2-50/+25
This reverts commit ed86b6250cd00ed6b7bdb81307bc66adba129cae. Reason for revert: Most Jenkins builds for that change were aborted after timing out, and many other Gerrit Jenkins and tinderbox builds now time out, too. It very much smells like that commit was the culprit. Change-Id: I5473c58957f92d63113e32f862ad9c114f9c844c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89803 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-02tdf#130986 Chart OOXML export: fix number format of custom labelBalazs Varga2-6/+17
Export correct sourceLinked attribute in c:dLbls/c:dLbl/c:numFmt, as in c:dLbls/c:numFmt. Change-Id: I0e52720b3cb2c99550a779763f01ba12f762050d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89638 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-02Make Chart Creation Wizard asyncSzymon Kłos2-25/+50
* FuInsertChart as a memeber in ScTabViewShell stores instance is needed to react on the dialog's result * CreationWizardUnoDlg converted to XAsynchronousExecutableDialog added dialog close handler which notifies listeners In the Online dialog become dead after closing, additional PostUserEvent was needed to kill the dialog after real close (without it user needed to select any cell to close dialog) * Reuse in Writer Change-Id: I9fe123d5c189d568f0edb4d36173a224a820a8a3 Reviewed-on: https://gerrit.libreoffice.org/79654 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/79571 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-03-01cid#1459020 Resource LeaksCaolán McNamara1-1/+2
Change-Id: I124a61ee34b315c4853ee0f1d96eb9ee45a76e8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89764 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-29tdf#130955 chart export: fix repeated custom labelsBalazs Varga2-0/+21
Do not add mCustomLabelText to aDataPointVector when we write leading empty data points, it is enough to add them, when we write data-point with style. Note: this fixes also DOCX import, when the embedded charts are imported by using ODF export in the background. Regression from commit: 7d2c7e7af04d9604d86d2d605ef95b9abb10966c (tdf#123206 Store custom label as chart:data-label) Change-Id: Ib3b370236323a57ac6800035d71321f7ee5dbe41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89504 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-28chart2: Fix the color uno command in ChartColorWrapperDennis Francis1-1/+4
The uno command for color depends on the property name. For LineColor it should be .uno:XLineColor and the only other case is FillColor for which it should be .uno:FillColor. Without this fix, on selecting the chart for editing the first time, the sidebar line-color control is disabled as a side-effect. Change-Id: Ia71ed2f6d9e0f31523f1415f3ee089fd9d7d1b2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89304 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 9a80969f3115fc33778005861442f91127344dc0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89677 Tested-by: Jenkins
2020-02-28Remove unused lokit-only selection properties in..Dennis Francis1-11/+0
CID string for charts. This is messing up the parsing of CID string in ObjectIdentifier::getObjectType() and elsewhere where parsing CID is attempted, which inturn causes at least the sidebar's chart line properties listboxes not getting updated. The selection properties insertion in chart CID was introduced in commit 3d705b98ca7f40a44f632f5565407274322ffde3 but these are not even used in online as of present. Change-Id: Ic8040d84e1ad16f182fc7bdc3a9f533ad9664458 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89300 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89697 Tested-by: Jenkins
2020-02-27tdf#108110 ODF chart: import/export of custom position of data point labelsBalazs Varga2-11/+29
using new attributes loext:custom-label-pos-x and loext:custom-label-pos-y of chart:data-point. This fixes also *import* of DOCX documents with embedded charts, related to the ODF usage in the background. Follow-up of commit 4223ff2be69f03e571464b0b09ad0d278918631b (tdf#48436 Chart: add CustomLabelPosition UNO API property) Change-Id: I985ce27cb6ce988948258d9eab0de13d01c72b97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89446 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-27tdf#130621 OOXML chart export: fix lost label placementBalazs Varga3-12/+6
of a newly created chart with default label placement settings. For example, default top label placement of a line chart changed to the right during the first OOXML export/import. Note: "Insert data labels" of the local menu and Insert->Data labels... of the main menu have been improved. Change-Id: I27bb57a0ebb3a2b3132cf47c0ea3a92ac2806380 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88542 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-27loplugin:constantparamNoel Grandin2-9/+9
Change-Id: I62a0b760e49e38a4565eebf272492159047dda5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89613 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27fix regression in chart keyboard handlingNoel Grandin3-5/+8
from commit 0528012fd0dc4b93645ef7790b0db9d1cecbae66 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Feb 3 10:05:12 2020 +0200 loplugin:constantparam Change-Id: I563f053a33898f971b382efd513979e459156c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89612 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-25loplugin:referencecastingNoel Grandin5-11/+15
getting --enable-pch=normal working with clang means that the plugins now have a better view on some stuff, so trigger more warnings Change-Id: I83ca010c0ef07c8106068362bb50a354e3cf7dae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-23Related tdf#130681: use "Standard" page style if nothing else foundJulien Nabet1-0/+2
Opening docx from https://bugs.documentfoundation.org/attachment.cgi?id=157891 I noticed this log: warn:chart2:151346:151346:chart2/source/view/main/ChartView.cxx:1406:DBG_UNHANDLED_EXCEPTION in void chart::{anonymous}::lcl_setDefaultWritingMode(const std::shared_ptr<chart::DrawModelWrapper>&, chart::ChartModel&) exception: com.sun.star.container.NoSuchElementException bt: 0 0x00007fffd652d857 in chart::(anonymous namespace)::lcl_setDefaultWritingMode(std::shared_ptr<chart::DrawModelWrapper> const&, chart::ChartModel&) (pDrawModelWrapper=std::shared_ptr<chart::DrawModelWrapper> (use count 1, weak count 0) = {...}, rModel=...) at /home/julien/lo/libreoffice/chart2/source/view/main/ChartView.cxx:1386 1 0x00007fffd6533d3f in chart::ChartView::createShapes() (this=0x55555b750050) at /home/julien/lo/libreoffice/chart2/source/view/main/ChartView.cxx:2461 2 0x00007fffd65340d6 in chart::ChartView::impl_updateView(bool) (this=0x55555b750050, bCheckLockedCtrler=true) at /home/julien/lo/libreoffice/chart2/source/view/main/ChartView.cxx:2530 3 0x00007fffd652fc7c in chart::ChartView::getExplicitValuesForAxis(com::sun::star::uno::Reference<com::sun::star::chart2::XAxis>, chart::ExplicitScaleData&, chart::ExplicitIncrementData&) (this=0x55555b750050, xAxis=uno::Reference to (chart::Axis *) 0x55555b88fe68, rExplicitScale=..., rExplicitIncrement=...) at /home/julien/lo/libreoffice/chart2/source/view/main/ChartView.cxx:1703 4 0x00007fffd5e00ce9 in chart::wrapper::Chart2ModelContact::getExplicitValuesForAxis(com::sun::star::uno::Reference<com::sun::star::chart2::XAxis> const&, chart::ExplicitScaleData&, chart::ExplicitIncrementData&) (this=0x55555b74b330, xAxis=uno::Reference to (chart::Axis *) 0x55555b88fe68, rOutExplicitScale=..., rOutExplicitIncrement=...) at /home/julien/lo/libreoffice/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx:141 5 0x00007fffd5e6203d in chart::wrapper::WrappedScaleProperty::getPropertyValue(chart::wrapper::WrappedScaleProperty::tScaleProperty, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&) const (this=0x55555b8214d0, eScaleProperty=chart::wrapper::WrappedScaleProperty::SCALE_PROP_MAX, xInnerPropertySet=uno::Reference to (chart::Axis *) 0x55555b88feb0) at /home/julien/lo/libreoffice/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx:365 6 0x00007fffd5e61256 in chart::wrapper::WrappedScaleProperty::getPropertyValue(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&) const (this=0x55555b8214d0, xInnerPropertySet=uno::Reference to (chart::Axis *) 0x55555b88feb0) at /home/julien/lo/libreoffice/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx:134 7 0x00007fffd6785913 in chart::WrappedProperty::getPropertyState(com::sun::star::uno::Reference<com::sun::star::beans::XPropertyState> const&) const (this=0x55555b8214d0, xInnerPropertyState=uno::Reference to (chart::Axis *) 0x55555b88ff10) at /home/julien/lo/libreoffice/chart2/source/tools/WrappedProperty.cxx:105 8 0x00007fffd678721a in chart::WrappedPropertySet::getPropertyState(rtl::OUString const&) (this=0x55555b818aa0, rPropertyName="Max") at /home/julien/lo/libreoffice/chart2/source/tools/WrappedPropertySet.cxx:285 9 0x00007fffd67874ae in chart::WrappedPropertySet::getPropertyStates(com::sun::star::uno::Sequence<rtl::OUString> const&) (this=0x55555b818aa0, rNameSeq=uno::Sequence of length 82 = {...}) at /home/julien/lo/libreoffice/chart2/source/tools/WrappedPropertySet.cxx:315 10 0x00007fffed317df6 in (anonymous namespace)::FilterPropertiesInfo_Impl::FillPropertyStateArray(std::__debug::vector<XMLPropertyState, std::allocator<XMLPropertyState> >&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, rtl::Reference<XMLPropertySetMapper> const&, bool) (this=0x55555b822090, rPropStates=std::__debug::vector of length 0, capacity 0, rPropSet= uno::Reference to (chart::wrapper::AxisWrapper *) 0x55555b818ac8, rPropMapper=rtl::Reference to 0x55555b7b80d0, bDefault=false) at /home/julien/lo/libreoffice/xmloff/source/style/xmlexppr.cxx:349 11 0x00007fffed319411 in SvXMLExportPropertyMapper::Filter_(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, bool, bool) const (this=0x55555b79d560, xPropSet=uno::Reference to (chart::wrapper::AxisWrapper *) 0x55555b818ac8, bDefault=false, bEnableFoFontFamily=false) at /home/julien/lo/libreoffice/xmloff/source/style/xmlexppr.cxx:616 12 0x00007fffed318e9a in SvXMLExportPropertyMapper::Filter(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, bool) const (this=0x55555b79d560, rPropSet=uno::Reference to (chart::wrapper::AxisWrapper *) 0x55555b818ac8, bEnableFoFontFamily=false) at /home/julien/lo/libreoffice/xmloff/source/style/xmlexppr.cxx:546 13 0x00007fffecfcc301 in SchXMLExportHelper_Impl::exportAxis(xmloff::token::XMLTokenEnum, xmloff::token::XMLTokenEnum, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, com::sun::star::uno::Reference<com::sun::star::chart2::XAxis> const&, rtl::OUString const&, bool, bool, bool, bool) (this=0x55555b833a80, eDimension=xmloff::token::XML_X, eAxisName=xmloff::token::XML_PRIMARY_X, rAxisProps=uno::Reference to (chart::wrapper::AxisWrapper *) 0x55555b818ac8, rChart2Axis=uno::Reference to (chart::Axis *) 0x55555b88fe68, rCategoriesRange="", bHasTitle=false, bHasMajorGrid=false, bHasMinorGrid=false, bExportContent=false) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:2260 14 0x00007fffecfcd203 in SchXMLExportHelper_Impl::exportAxes(com::sun::star::uno::Reference<com::sun::star::chart::XDiagram> const&, com::sun::star::uno::Reference<com::sun::star::chart2::XDiagram> const&, bool) (this=0x55555b833a80, xDiagram=uno::Reference to (chart::wrapper::DiagramWrapper *) 0x55555b8be9b8, xNewDiagram=uno::Reference to (chart::Diagram *) 0x55555b883ad8, bExportContent=false) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:2401 15 0x00007fffecfca651 in SchXMLExportHelper_Impl::exportPlotArea(com::sun::star::uno::Reference<com::sun::star::chart::XDiagram> const&, com::sun::star::uno::Reference<com::sun::star::chart2::XDiagram> const&, com::sun::star::awt::Size const&, bool, bool) (this=0x55555b833a80, xDiagram=uno::Reference to (chart::wrapper::DiagramWrapper *) 0x55555b8be9b8, xNewDiagram=uno::Reference to (chart::Diagram *) 0x55555b883ad8, rPageSize=..., bExportContent=false, bIncludeTable=false) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:1925 16 0x00007fffecfc6ebc in SchXMLExportHelper_Impl::parseDocument(com::sun::star::uno::Reference<com::sun::star::chart::XChartDocument> const&, bool, bool) (this=0x55555b833a80, rChartDoc= uno::Reference to (chart::wrapper::ChartDocumentWrapper *) 0x55555b74b208, bExportContent=false, bIncludeTable=false) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:1415 17 0x00007fffecfc50ce in SchXMLExportHelper_Impl::collectAutoStyles(com::sun::star::uno::Reference<com::sun::star::chart::XChartDocument> const&) (this=0x55555b833a80, rChartDoc=uno::Reference to (chart::wrapper::ChartDocumentWrapper *) 0x55555b74b208) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:1050 18 0x00007fffecfd5207 in SchXMLExport::collectAutoStyles() (this=0x55555b7b4a00) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:3556 19 0x00007fffecfd530d in SchXMLExport::ExportAutoStyles_() (this=0x55555b7b4a00) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:3568 20 0x00007fffed0c407d in SvXMLExport::ImplExportAutoStyles() (this=0x55555b7b4a00) at /home/julien/lo/libreoffice/xmloff/source/core/xmlexp.cxx:1152 21 0x00007fffed0c527f in SvXMLExport::exportDoc(xmloff::token::XMLTokenEnum) (this=0x55555b7b4a00, eClass=xmloff::token::XML_CHART) at /home/julien/lo/libreoffice/xmloff/source/core/xmlexp.cxx:1404 22 0x00007fffecfd502f in SchXMLExport::exportDoc(xmloff::token::XMLTokenEnum) (this=0x55555b7b4a00, eClass=xmloff::token::XML_CHART) at /home/julien/lo/libreoffice/xmloff/source/chart/SchXMLExport.cxx:3534 23 0x00007fffed0c20d9 in SvXMLExport::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x55555b7b4a00, aDescriptor=uno::Sequence of length 6 = {...}) at /home/julien/lo/libreoffice/xmloff/source/core/xmlexp.cxx:811 Change-Id: I21a6b54f3340b0423a0b12f39a620f71d96ff565 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88763 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-21Drop o3tl::optional wrapperStephan Bergmann3-6/+6
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-21tdf#130657 OOXML chart import: fix charts without CrossBetweenBalazs Varga2-0/+17
by using default values for ShiftedCategoryPosition. Regression from commit 111c260ab2883b7906f1a66e222dbf4dc3c58c4f (tdf#127777 OOXML chart export: fix "CrossBetween" for not imported charts) Change-Id: Idd48a8343e7d6609b487daf7182e9716f2f5e01f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88709 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-20tdf#126076 XLSX export: fix automatic line chart markersTünde Tóth2-0/+14
The default automatic line chart markers in XLSX spreadsheets created with Microsoft Excel 2010 became squares after export. Change-Id: I58a3e10212608a356eef8fbd1e100eda4dbebaca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88461 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-20tdf#90749 chart: add leader lines to custom data label positionsBalazs Varga3-1/+49
also export them as CustomXML extension for MSO interoperability. Note: pie chart is not yet supported. See commit 4223ff2be69f03e571464b0b09ad0d278918631b ( tdf#48436 Chart: add CustomLabelPosition UNO API property) Change-Id: Ia8142408414d4ad8f689d789386db50038ed13f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88531 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-17tdf#130590 Chart OOXML export: fix custom label positionBalazs Varga2-0/+19
in case of all chart types except pie chart. Follow-up of commit 4223ff2be69f03e571464b0b09ad0d278918631b (tdf#48436 Chart: add CustomLabelPosition UNO API property) Change-Id: I3ff1ca13928315f27988ae27c462a2f05354bc49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88371 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-17remove some unnecessary button.hxx includesCaolán McNamara1-2/+1
and update pches Change-Id: I61ca0be7a838e4eec6c41e0ece58d8a6b0e64c37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17weld SelectorListBox Item WindowCaolán McNamara4-66/+120
Change-Id: I9752d03d9a70831d6e15fe3ac3ebdfc7d2728550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88853 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-16clang-format chart2 with under 5-percent lines of changeMuhammet Kara11-16/+9
Change-Id: Ia60d23c7a75086c2a68e0e295b99a3df3dfd164f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88771 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-15chart sidebar chart type alignment updateandreas kainz1-32/+20
Change-Id: I22a72ec8354ea3832ab27f362b1487894283305e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88749 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-13tdf#130225 implement ODF export of deleted legend entries of pie chartsTünde Tóth2-0/+16
Follow-up of the following commits related to the new UNO property DeletedLegendEntries for pie charts: commit 86be3422cd55fa9e44104f1628648061bb6a3495 (tdf#129857 Chart OOXML export: fix deleted legend entries) commit 6e847aa817999ab18acd534f9e6a86685bb268fc (tdf#129859 XLSX import: don't show deleted legend entries) Change-Id: Id24cddefa83e50dde1ec6555d02891753483dd5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88018 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-13tdf#119138 Show custom chart title if autoTitleDeleted is missingGabor Kelemen2-0/+13
autoTitleDeleted might be omitted by generators other than Excel while providing custom title. mbAutoTitleDel is set only based on the attribute value and the default also varies on whether MSO 2007 or newer is the generator, see tdf#78080 ECMA-376 Part 1 at 21.2.2.7 says: A value of 1 or true specifies that the property is applied. This is the default value for this attribute, and is implied when the parent element is present, but this attribute is omitted. Change-Id: If3457fe850e13ae8af207bb9beceecc9e887b797 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88151 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-12clang-analyzer-deadcode.DeadStoresNoel Grandin1-4/+0
Change-Id: Ifa384933569b27d0d08eb479bb95b799163ae386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88450 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-09Fix undo and redo dropdowns in non-sfx2 modulesMaxim Monastirsky2-7/+24
after commit c34edadf5bd3d1d9f3c9c056af28b8964d8f1ca0 ("rework SvxUndoRedoControl to be a PopupWindowController") accidentally enabled them there, instead of the simple buttons those modules used to have. Just implement the necessary stuff, instead of hiding the dropdown again. Change-Id: Ic93114f7f3cec8e96f3389ceb0d52552cde02a83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88333 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-08replace some more copy/clear with swapNoel Grandin1-5/+3
Change-Id: I6501dd59682d2605e9b9856c2deaa02a873ce641 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88239 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07Fix typoAndrea Gelmini1-1/+1
Change-Id: Idf99108e6f7813551a8cee2e8d7b990de8a36ebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88251 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-07tdf#94234 Add Period as chart data label separatorGabor Kelemen3-1/+3
Change-Id: I50b9662b22bdb10086e6aa557622566591135514 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88139 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-02-07tdf#130380 Chart: Fix area chart data labels positionTünde Tóth1-1/+4
Regression from commit: f8966bb398cf0623be841c618b123866801a063c (tdf#130031 Chart OOXML import: fix area chart data label position) Change-Id: Iafcbacb0ecf6f8a175adbf0782ee3e3a1185a726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87881 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-02-04tdf#130389: Data ranges dialog, data series tab, move up/down reversedJulien Nabet1-1/+1
Change-Id: I6a12acacec9bad33cab9fd86b0ffa7193ee74b75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87921 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-02-04tdf#130242 chart: default center label placement in stacked area chartsTünde Tóth1-2/+18
instead of top label placement, like MSO does (or LO has already done in stacked bar charts) for readability. Change-Id: Icac6e8703d0d04122f9cc28254b053ee9fd434ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87846 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-02-03loplugin:constantparamNoel Grandin7-15/+12
Change-Id: If2dee122bf07dc179fd8f6e766442ec1891a5f3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87845 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-03GtkImage property should be icon_name in welded dialogsCaolán McNamara1-4/+4
Change-Id: I8e832599854e3ef52f25167e35470939c6e75bd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87839 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-01make update_pch also consider files in <module>/src/**/incLuboš Luňák3-4/+151
With --enable-pch=full there's not much difference between a "public" header in <module>/inc and a private one in <module>/src/somewhere/inc . And since the script searches recursively, this apparently helps to find even more headers for lower pch levels. Change-Id: I8483d0aa5b4fea5a59107c20a8aa5f1ef694af0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87799 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-31tdf#130032 Chart OOXML Import: fix data label custom positionBalazs Varga3-4/+33
in case of all chart types except pie chart. Clean up commit 4223ff2be69f03e571464b0b09ad0d278918631b (tdf#48436 Chart: add CustomLabelPosition UNO API property). Note: use the correct default OOXML label placement in case of radar charts. Change-Id: I9a8f509304b3c70d879c8c6a95bc91d15ac28521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87759 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-31new loplugin:namespaceindentationNoel Grandin30-30/+30
check indentation of braces in namespace decls, and the comments that often appear with them. This is my penance for messing up the indentation with clang-tidy-modernize-namespaces. As such I have limited it to new-style namespaces for now, and the check is off by default. Change-Id: I4db7f10a81c79bc0eece8f8e3ee564da8bc7f168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-30tdf#48436 Chart: add CustomLabelPosition UNO API propertyBalazs Varga16-12/+141
and CUSTOM DataLabelPlacement to support custom data label positions, and its initial implementation: only UI support with OOXML import (tdf#130030), yet. Change-Id: I01d986071d78ae3e2a5f43d5711e9f60b8410c21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86859 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-29tdf#124176: Use pragma once instead of header guardPelin Kuran5-18/+8
Change-Id: If7c8b03238889a084070d9e96133b5cccecbe807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87660 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-29tdf#130237 OOXML chart export: fix incomplete 3D area chartBalazs Varga2-0/+14
by exporting its z-axis properties into <serAx> element. Data series of 3D area charts were “transparent” or incomplete opening with MSO, because we exported z-axis as a category axis. Change-Id: If7d8c15aa738cc44c736cd37d2be30d0eb15538f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87506 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-01-28tdf#108107 OOXML chart: fix format of custom data point labelsBalazs Varga2-0/+12
Do not overwrite the property of moved data point labels with default values, but use the data series properties for these labels. Change-Id: Id27fa1c2d8286584b2b87b7eb7a64fd9b416dc34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87463 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-28tdf#130031 Chart OOXML import: fix area chart data label positionTünde Tóth2-5/+12
Default data label positioning of area charts in Excel is vertically centered between the X axes and the data point. In LibreOffice the data labels positioning was above the data point. Change-Id: Icff3e2554dee7b5ee264bc6f9579a84852da6f7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86927 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
generated by cgit v1.2.3 (git 2.39.1) at 2025-03-28 22:58:56 +0000